Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-6539: [R] Provide mechanism to write out old format #5420

Closed

Conversation

romainfrancois
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@3c13d22). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5420   +/-   ##
=========================================
  Coverage          ?   76.11%           
=========================================
  Files             ?       56           
  Lines             ?     3576           
  Branches          ?        0           
=========================================
  Hits              ?     2722           
  Misses            ?      854           
  Partials          ?        0
Impacted Files Coverage Δ
r/src/arrow_types.h 96% <ø> (ø)
r/R/record-batch-writer.R 60% <ø> (ø)
r/src/parquet.cpp 75% <ø> (ø)
r/R/arrowExports.R 71.96% <100%> (ø)
r/src/recordbatchwriter.cpp 100% <100%> (ø)
r/src/arrowExports.cpp 71.66% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c13d22...b00ebf8. Read the comment docs.

@romainfrancois romainfrancois marked this pull request as ready for review September 20, 2019 07:16
@romainfrancois
Copy link
Contributor Author

@javierluraschi is this enough for sparklyr needs ?

@nealrichardson
Copy link
Contributor

sparklyr uses write_arrow: https://github.com/rstudio/sparklyr/blob/master/R/core_arrow.R#L19

And when writing to a raw vector, it uses RecordBatchStreamWriter: https://github.com/apache/arrow/blob/master/r/R/write-arrow.R#L86

So I think we're covered. I'll merge.

@nealrichardson nealrichardson changed the title ARROW-6313 [R] Provide mechanism to write out old format ARROW-6539: [R] Provide mechanism to write out old format Sep 20, 2019
@romainfrancois romainfrancois deleted the ARROW-6313/old_format branch September 23, 2019 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants