ARROW-7170: [C++] Fix linking with bundled ORC #5834
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
force-pushed
the
ARROW-7170-orc-link-failure
branch
from
c5ae648
to
57e811b
Compare
kou
reviewed
Nov 14, 2019
| GTest::GTest | ||
| Snappy::snappy | ||
| LZ4::lz4 | ||
| ZLIB::ZLIB) |
There was a problem hiding this comment.
Do we need ARROW_WITH_XXX check?
For example:
if(ARROW_WITH_LZ4)
list(APPEND ORC_MIN_TEST_LIBS LZ4::lz4)
endif()There was a problem hiding this comment.
Hmm, I don't think so? LZ4 is not optional when building ORC, AFAICT.
There was a problem hiding this comment.
And we have this in cpp/CMakeLists.txt:
if(ARROW_ORC)
set(ARROW_WITH_LZ4 ON)
set(ARROW_WITH_SNAPPY ON)
set(ARROW_WITH_ZLIB ON)
endif()
Note I still get an error later: ``` [libprotobuf ERROR google/protobuf/descriptor_database.cc:120] File already exists in database: orc_proto.proto [libprotobuf FATAL google/protobuf/descriptor.cc:1359] CHECK failed: GeneratedDatabase()->Add(encoded_file_descriptor, size): terminate called after throwing an instance of 'google::protobuf::FatalException' what(): CHECK failed: GeneratedDatabase()->Add(encoded_file_descriptor, size): Abandon ```
pitrou
force-pushed
the
ARROW-7170-orc-link-failure
branch
from
57e811b
to
65c1c5d
Compare
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note I still get an error later: