ARROW-7468: [Python] fix typos #6096
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
reviewed
Dec 24, 2019
python/pyarrow/tests/test_parquet.py
Outdated
| @@ -2803,24 +2803,24 @@ def _make_dataset_for_pickling(tempdir, N=100): | |||
| pytest.param(pytest.importorskip('cloudpickle'), id='cloudpickle') | |||
| ]) | |||
| def test_pickle_dataset(tempdir, datadir, pickler): | |||
| def is_pickleable(obj): | |||
| def is_picklable(obj): | |||
There was a problem hiding this comment.
I think that "pickle"-able is valid.
There was a problem hiding this comment.
I see. I am neutral on this. I just followed this API.
I have just reverted these changes.
There was a problem hiding this comment.
OK. I'll merge this pull request without these changes for now.
If some Python experts say "picklable" is better, we will use "picklable".
There was a problem hiding this comment.
The Python documentation uses "picklable" https://docs.python.org/3/library/pickle.html
There was a problem hiding this comment.
Oh... Sorry for my wrong comment...
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes typos in files under
pythondirectory.