Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-8187: [R] Make test assertions robust to i18n #6695

Closed
wants to merge 2 commits into from

Conversation

nealrichardson
Copy link
Member

No description provided.

@github-actions
Copy link

@nealrichardson
Copy link
Member Author

@pitrou can you confirm that this resolves the failures you saw?

@pitrou
Copy link
Member

pitrou commented Mar 24, 2020

I still get this, but other failures are fixed:

══ Warnings ════════════════════════════════════════════════════════════════════
1. Filtering on a column that doesn't exist errors correctly (@test-dplyr.R#169) - Filter expression not implemented in Arrow: not_a_col == 42; pulling data into R

══ Failed ══════════════════════════════════════════════════════════════════════
── 1. Failure: Filtering on a column that doesn't exist errors correctly (@test-
`batch %>% filter(not_a_col == 42) %>% collect()` threw an error with unexpected message.
Expected match: "object 'not_a_col' not found"
Actual message: "Cannot extract rows with an object of class NULL"
Backtrace:
  1. testthat::expect_error(...) testthat/test-dplyr.R:169:2
  9. dplyr::filter(., not_a_col == 42)
 17. arrow:::collect.arrow_dplyr_query(.data)
 20. arrow:::`[.RecordBatch`(x$.data, x$filtered_rows, colnames)
 21. arrow:::filter_rows(x, i, ...)

@nealrichardson
Copy link
Member Author

Merging; dotnet release test cannot be related to this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants