Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-8457: [C++] Add expected results for ArrowSchema in big-endian #6936

Closed
wants to merge 1 commit into from

Conversation

kiszk
Copy link
Member

@kiszk kiszk commented Apr 14, 2020

This PR adds expected results for ArrowSchema in big-endian while the current tests have them only in litte-endian. According to the specification of ArrowSchema, ArrowSchema uses native endian format on the CPU.

@pitrou
Copy link
Member

pitrou commented Apr 14, 2020

Thank you for catching this!

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Will wait for CI.

@github-actions
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants