ARROW-8660: [C++][Gandiva] Reduce usage of Boost in Gandiva codebase #7077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nealrichardson
requested changes
May 1, 2020
There was a problem hiding this comment.
Could you please also remove the hash library reference from https://github.com/apache/arrow/blob/master/cpp/build-support/trim-boost.sh#L41 ?
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this while reading the Gandiva codebase as part of the C++ precompiled kernels revamp project. In general we've tried to reduce our use of Boost -- if we can eliminate Boost altogether from library builds in the future that would be ideal.
I replaced usages of
boost::hash_combine(vendored),boost::iequals(reimplemented), andboost::algorithm::to_lower_copy(reimplemented). There's a little bit of code scrubbing / IWYU fixes also.The only Boost remaining is boost/multiprecision (for int256_t)