New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-9266: [Python][Packaging] Enable S3 support in macOS wheels #8315
Conversation
@github-actions crossbow submit wheel-osx-mavericks-cp36m wheel-osx-high-sierra-cp36m |
Revision: 430ffdf Submitted crossbow builds: ursa-labs/crossbow @ actions-571
|
@github-actions crossbow submit wheel-osx-* |
Revision: 430ffdf Submitted crossbow builds: ursa-labs/crossbow @ actions-572 |
@github-actions crossbow submit wheel-osx-* |
Revision: 50aaa55 Submitted crossbow builds: ursa-labs/crossbow @ actions-598 |
@kszucs please rebase |
@github-actions crossbow submit wheel-osx-* |
Revision: 16a9f09 Submitted crossbow builds: ursa-labs/crossbow @ actions-604 |
dev/tasks/python-wheels/osx-build.sh
Outdated
@@ -67,6 +67,7 @@ function build_wheel { | |||
-DARROW_GANDIVA=OFF \ | |||
-DARROW_GRPC_USE_SHARED=OFF \ | |||
-DARROW_HDFS=ON \ | |||
-DARROW_S3=${ARROW_S3} \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you keep alphabetical order?
dev/tasks/python-wheels/osx-build.sh
Outdated
@@ -103,6 +104,7 @@ function build_wheel { | |||
export PYARROW_WITH_DATASET=1 | |||
export PYARROW_WITH_FLIGHT=1 | |||
export PYARROW_WITH_HDFS=1 | |||
export PYARROW_WITH_S3=${ARROW_S3} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
@github-actions crossbow submit wheel-osx-* |
Revision: 97b5b32 Submitted crossbow builds: ursa-labs/crossbow @ actions-605 |
@github-actions crossbow submit wheel-osx-* |
The successful builds take between ~42-45 minutes but occasionally it exceeds the 50m build time limit. Sadly we can't utilize travis' build cache since crossbow always creates new branches and the fallback default branch won't have any cache entries. |
Revision: c40e6e4 Submitted crossbow builds: ursa-labs/crossbow @ actions-611 |
@github-actions crossbow submit wheel-osx-mavericks-cp38 |
Revision: 7bcd83e Submitted crossbow builds: ursa-labs/crossbow @ actions-613
|
Does this explain why some of the nightly builds seem to be intermittently missing certain macOS wheels? E.g., sometimes for example there's no cp38 wheel, only for that wheel to come back with the next nightly publish. |
We could run something on |
I think @nealrichardson is right: my understanding is that travis caching will try to pull from default branch if no cache is available for current branch, so the warming strategy could work. |
We would need to merge the latests tasks (multiple .travis.yml files into a single one) generated by crossbow to master automatically which would be rather complicated. Crossbow also creates diverged branches from master at the moment. We can make a jira about supporting CI caches in crossbow though I can't see a generic solution at the moment. |
Could you send me build links? I don't entirely see your question. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, merging.
Depends on apache#8304 Closes apache#8315 from kszucs/macos3 Authored-by: Krisztián Szűcs <szucs.krisztian@gmail.com> Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Depends on apache#8304 Closes apache#8315 from kszucs/macos3 Authored-by: Krisztián Szűcs <szucs.krisztian@gmail.com> Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Depends on #8304