Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-9266: [Python][Packaging] Enable S3 support in macOS wheels #8315

Closed
wants to merge 4 commits into from

Conversation

kszucs
Copy link
Member

@kszucs kszucs commented Oct 1, 2020

Depends on #8304

@kszucs
Copy link
Member Author

kszucs commented Oct 1, 2020

@github-actions crossbow submit wheel-osx-mavericks-cp36m wheel-osx-high-sierra-cp36m

@github-actions
Copy link

github-actions bot commented Oct 1, 2020

Revision: 430ffdf

Submitted crossbow builds: ursa-labs/crossbow @ actions-571

Task Status
wheel-osx-high-sierra-cp36m TravisCI
wheel-osx-mavericks-cp36m TravisCI

@github-actions
Copy link

github-actions bot commented Oct 1, 2020

@kszucs
Copy link
Member Author

kszucs commented Oct 1, 2020

@github-actions crossbow submit wheel-osx-*

@github-actions
Copy link

github-actions bot commented Oct 1, 2020

Revision: 430ffdf

Submitted crossbow builds: ursa-labs/crossbow @ actions-572

Task Status
wheel-osx-high-sierra-cp35m TravisCI
wheel-osx-high-sierra-cp36m TravisCI
wheel-osx-high-sierra-cp37m TravisCI
wheel-osx-high-sierra-cp38 TravisCI
wheel-osx-mavericks-cp35m TravisCI
wheel-osx-mavericks-cp36m TravisCI
wheel-osx-mavericks-cp37m TravisCI
wheel-osx-mavericks-cp38 TravisCI

@kszucs
Copy link
Member Author

kszucs commented Oct 5, 2020

@github-actions crossbow submit wheel-osx-*

@github-actions
Copy link

github-actions bot commented Oct 5, 2020

Revision: 50aaa55

Submitted crossbow builds: ursa-labs/crossbow @ actions-598

Task Status
wheel-osx-high-sierra-cp35m TravisCI
wheel-osx-high-sierra-cp36m TravisCI
wheel-osx-high-sierra-cp37m TravisCI
wheel-osx-high-sierra-cp38 TravisCI
wheel-osx-mavericks-cp35m TravisCI
wheel-osx-mavericks-cp36m TravisCI
wheel-osx-mavericks-cp37m TravisCI
wheel-osx-mavericks-cp38 TravisCI

@nealrichardson
Copy link
Contributor

@kszucs please rebase

@kszucs
Copy link
Member Author

kszucs commented Oct 5, 2020

@github-actions crossbow submit wheel-osx-*

@github-actions
Copy link

github-actions bot commented Oct 5, 2020

Revision: 16a9f09

Submitted crossbow builds: ursa-labs/crossbow @ actions-604

Task Status
wheel-osx-high-sierra-cp35m TravisCI
wheel-osx-high-sierra-cp36m TravisCI
wheel-osx-high-sierra-cp37m TravisCI
wheel-osx-high-sierra-cp38 TravisCI
wheel-osx-mavericks-cp35m TravisCI
wheel-osx-mavericks-cp36m TravisCI
wheel-osx-mavericks-cp37m TravisCI
wheel-osx-mavericks-cp38 TravisCI

@@ -67,6 +67,7 @@ function build_wheel {
-DARROW_GANDIVA=OFF \
-DARROW_GRPC_USE_SHARED=OFF \
-DARROW_HDFS=ON \
-DARROW_S3=${ARROW_S3} \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you keep alphabetical order?

@@ -103,6 +104,7 @@ function build_wheel {
export PYARROW_WITH_DATASET=1
export PYARROW_WITH_FLIGHT=1
export PYARROW_WITH_HDFS=1
export PYARROW_WITH_S3=${ARROW_S3}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

@kszucs
Copy link
Member Author

kszucs commented Oct 6, 2020

@github-actions crossbow submit wheel-osx-*

@github-actions
Copy link

github-actions bot commented Oct 6, 2020

Revision: 97b5b32

Submitted crossbow builds: ursa-labs/crossbow @ actions-605

Task Status
wheel-osx-high-sierra-cp35m TravisCI
wheel-osx-high-sierra-cp36m TravisCI
wheel-osx-high-sierra-cp37m TravisCI
wheel-osx-high-sierra-cp38 TravisCI
wheel-osx-mavericks-cp35m TravisCI
wheel-osx-mavericks-cp36m TravisCI
wheel-osx-mavericks-cp37m TravisCI
wheel-osx-mavericks-cp38 TravisCI

@kszucs
Copy link
Member Author

kszucs commented Oct 7, 2020

@github-actions crossbow submit wheel-osx-*

@kszucs
Copy link
Member Author

kszucs commented Oct 7, 2020

The successful builds take between ~42-45 minutes but occasionally it exceeds the 50m build time limit. Sadly we can't utilize travis' build cache since crossbow always creates new branches and the fallback default branch won't have any cache entries.

@github-actions
Copy link

github-actions bot commented Oct 7, 2020

Revision: c40e6e4

Submitted crossbow builds: ursa-labs/crossbow @ actions-611

Task Status
wheel-osx-high-sierra-cp35m TravisCI
wheel-osx-high-sierra-cp36m TravisCI
wheel-osx-high-sierra-cp37m TravisCI
wheel-osx-high-sierra-cp38 TravisCI
wheel-osx-mavericks-cp35m TravisCI
wheel-osx-mavericks-cp36m TravisCI
wheel-osx-mavericks-cp37m TravisCI
wheel-osx-mavericks-cp38 TravisCI

@kszucs
Copy link
Member Author

kszucs commented Oct 7, 2020

@github-actions crossbow submit wheel-osx-mavericks-cp38

@github-actions
Copy link

github-actions bot commented Oct 7, 2020

Revision: 7bcd83e

Submitted crossbow builds: ursa-labs/crossbow @ actions-613

Task Status
wheel-osx-mavericks-cp38 TravisCI

@corleyma
Copy link
Contributor

corleyma commented Oct 7, 2020

The successful builds take between ~42-45 minutes but occasionally it exceeds the 50m build time limit. Sadly we can't utilize travis' build cache since crossbow always creates new branches and the fallback default branch won't have any cache entries.

Does this explain why some of the nightly builds seem to be intermittently missing certain macOS wheels? E.g., sometimes for example there's no cp38 wheel, only for that wheel to come back with the next nightly publish.

@nealrichardson
Copy link
Contributor

Sadly we can't utilize travis' build cache since crossbow always creates new branches and the fallback default branch won't have any cache entries.

We could run something on master on the crossbow repo to warm the cache.

@corleyma
Copy link
Contributor

corleyma commented Oct 7, 2020

I think @nealrichardson is right: my understanding is that travis caching will try to pull from default branch if no cache is available for current branch, so the warming strategy could work.

@kszucs
Copy link
Member Author

kszucs commented Oct 7, 2020

Sadly we can't utilize travis' build cache since crossbow always creates new branches and the fallback default branch won't have any cache entries.

We could run something on master on the crossbow repo to warm the cache.

We would need to merge the latests tasks (multiple .travis.yml files into a single one) generated by crossbow to master automatically which would be rather complicated. Crossbow also creates diverged branches from master at the moment.

We can make a jira about supporting CI caches in crossbow though I can't see a generic solution at the moment.

@kszucs
Copy link
Member Author

kszucs commented Oct 7, 2020

Does this explain why some of the nightly builds seem to be intermittently missing certain macOS wheels? E.g., sometimes for example there's no cp38 wheel, only for that wheel to come back with the next nightly publish.

Could you send me build links? I don't entirely see your question.

Copy link
Member Author

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, merging.

@kszucs kszucs closed this in 732e333 Oct 7, 2020
emkornfield pushed a commit to emkornfield/arrow that referenced this pull request Oct 16, 2020
Depends on apache#8304

Closes apache#8315 from kszucs/macos3

Authored-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
GeorgeAp pushed a commit to sirensolutions/arrow that referenced this pull request Jun 7, 2021
Depends on apache#8304

Closes apache#8315 from kszucs/macos3

Authored-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants