Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-10863: [Python] Fix pandas skip in ExtensionArray.to_pandas test #8934

Closed
wants to merge 1 commit into from
Closed

ARROW-10863: [Python] Fix pandas skip in ExtensionArray.to_pandas test #8934

wants to merge 1 commit into from

Conversation

jorisvandenbossche
Copy link
Member

No description provided.

@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit -g integration wheel

@jorisvandenbossche jorisvandenbossche mentioned this pull request Dec 16, 2020
Closed
@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-10863

@github-actions
Copy link

Revision: 6785117

Submitted crossbow builds: ursa-labs/crossbow @ actions-798

Task Status
test-conda-python-3.6-pandas-0.23 Github Actions
test-conda-python-3.7-dask-latest Github Actions
test-conda-python-3.7-hdfs-2.9.2 Github Actions
test-conda-python-3.7-kartothek-latest Github Actions
test-conda-python-3.7-kartothek-master Github Actions
test-conda-python-3.7-pandas-latest Github Actions
test-conda-python-3.7-pandas-master Github Actions
test-conda-python-3.7-spark-branch-3.0 Github Actions
test-conda-python-3.7-turbodbc-latest Github Actions
test-conda-python-3.7-turbodbc-master Github Actions
test-conda-python-3.8-dask-master Github Actions
test-conda-python-3.8-jpype Github Actions
test-conda-python-3.8-pandas-latest Github Actions
test-conda-python-3.8-pandas-nightly Github Actions
test-conda-python-3.8-spark-master Github Actions

@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit -g wheel

@github-actions
Copy link

Revision: 6785117

Submitted crossbow builds: ursa-labs/crossbow @ actions-799

Task Status
wheel-manylinux1-cp36m Azure
wheel-manylinux1-cp37m Azure
wheel-manylinux1-cp38 Azure
wheel-manylinux1-cp39 Azure
wheel-manylinux2010-cp36m Azure
wheel-manylinux2010-cp37m Azure
wheel-manylinux2010-cp38 Azure
wheel-manylinux2010-cp39 Azure
wheel-manylinux2014-cp36m Azure
wheel-manylinux2014-cp37m Azure
wheel-manylinux2014-cp38 Azure
wheel-manylinux2014-cp39 Azure
wheel-osx-high-sierra-cp36m TravisCI
wheel-osx-high-sierra-cp37m TravisCI
wheel-osx-high-sierra-cp38 TravisCI
wheel-osx-mavericks-cp36m TravisCI
wheel-osx-mavericks-cp37m TravisCI
wheel-osx-mavericks-cp38 TravisCI
wheel-win-cp36m Github Actions
wheel-win-cp37m Github Actions
wheel-win-cp38 Github Actions

@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit -g integration

@github-actions
Copy link

Revision: c83bdd9

Submitted crossbow builds: ursa-labs/crossbow @ actions-800

Task Status
test-conda-python-3.6-pandas-0.23 Github Actions
test-conda-python-3.7-dask-latest Github Actions
test-conda-python-3.7-hdfs-2.9.2 Github Actions
test-conda-python-3.7-kartothek-latest Github Actions
test-conda-python-3.7-kartothek-master Github Actions
test-conda-python-3.7-pandas-latest Github Actions
test-conda-python-3.7-pandas-master Github Actions
test-conda-python-3.7-spark-branch-3.0 Github Actions
test-conda-python-3.7-turbodbc-latest Github Actions
test-conda-python-3.7-turbodbc-master Github Actions
test-conda-python-3.8-dask-master Github Actions
test-conda-python-3.8-jpype Github Actions
test-conda-python-3.8-pandas-latest Github Actions
test-conda-python-3.8-pandas-nightly Github Actions
test-conda-python-3.8-spark-master Github Actions

@pitrou
Copy link
Member

pitrou commented Dec 16, 2020

@jorisvandenbossche Are you happy with the build results? If so, will merge.

kou
kou approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Thanks!

@kou kou closed this in 13cf86f Dec 16, 2020
@jorisvandenbossche jorisvandenbossche deleted the ARROW-10863-ext-to-pandas-fixup branch December 16, 2020 20:31
@jorisvandenbossche
Copy link
Member Author

Hmm, the pandas master/nightly builds are failing, and it is in tests that I touched, it seems unrelated (just by accident that a recent change in pandas master also impacted those tests). It seems that the pytest monkeypatching functionality cannot handle inherited methods.
Will take a look at that tomorrow.

GeorgeAp pushed a commit to sirensolutions/arrow that referenced this pull request Jun 7, 2021
@jorisvandenbossche @GeorgeAp
ARROW-10863: [Python] Fix pandas skip in ExtensionArray.to_pandas test
99cf5b2 
Closes apache#8934 from jorisvandenbossche/ARROW-10863-ext-to-pandas-fixup

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This was referenced Dec 16, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

Assignees
No one assigned
Labels
Component: Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jorisvandenbossche @pitrou @kou