ARROW-10881: [C++] Fix EXC_BAD_ACCESS in PutSpaced #9097
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to add a unit test? |
|
@github-actions autotune |
|
@xhochy autotune isn't working at the moment--INFRA has blocked some of the Actions we use, including on that workflow. See https://issues.apache.org/jira/browse/INFRA-21239 |
pitrou
requested changes
Jan 5, 2021
cpp/src/parquet/encoding.cc
Outdated
| if (valid_bits != NULLPTR) { | ||
| PARQUET_ASSIGN_OR_THROW(auto buffer, ::arrow::AllocateBuffer(num_values * sizeof(T), | ||
| this->memory_pool())); | ||
| T* data_ = reinterpret_cast<T*>(buffer->mutable_data()); |
There was a problem hiding this comment.
Underscore-terminated variable names are only for attributes. Can you use another name? (e.g. non_spaced_data)
| int num_valid_values = num_values; | ||
| if (valid_bits != NULLPTR) { | ||
| PARQUET_ASSIGN_OR_THROW(auto buffer, ::arrow::AllocateBuffer(num_values * sizeof(T), | ||
| this->memory_pool())); |
There was a problem hiding this comment.
It seems buffer will be deallocated at the end of this if block, but you're using its contents afterwards (when calling Put).
| const T* data = src; | ||
| int num_valid_values = num_values; | ||
| if (valid_bits != NULLPTR) { | ||
| PARQUET_ASSIGN_OR_THROW(auto buffer, ::arrow::AllocateBuffer(num_values * sizeof(T), |
cpp/src/parquet/encoding.h
Outdated
| return ::arrow::util::internal::SpacedExpand<T>(buffer, num_values, null_count, | ||
| valid_bits, valid_bits_offset); | ||
| } else { | ||
| return num_values; |
There was a problem hiding this comment.
Why don't you call Decode in this branch?
pitrou
approved these changes
Jan 5, 2021
|
CI tests are green on my fork (except for the usual Homebrew dependency install failures). |
|
@pitrou Thanks! |
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
Closes apache#9097 from xhochy/ARROW-10881 Lead-authored-by: Uwe L. Korn <uwe.korn@quantco.com> Co-authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.