ARROW-11777: [Rust] impl AsRef for StringBuilder/BinaryBuilder #9570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevi-me
changed the title
alamb
approved these changes
Feb 25, 2021
There was a problem hiding this comment.
@Max-Meldrum this looks like a great improvement. Thank you for the contribution
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
This patch adds impl AsRef<[u8]> to the append_value/append of StringBuilder and BinaryBuilder. ```rust pub fn append_value(&mut self, value: impl AsRef<[u8]>) -> Result<()> ``` Non-breaking change that will enable data to be passed as value as well. Closes apache#9570 from Max-Meldrum/as_ref_patch Authored-by: Max Meldrum <max@meldrum.se> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
This patch adds impl AsRef<[u8]> to the append_value/append of StringBuilder and BinaryBuilder. ```rust pub fn append_value(&mut self, value: impl AsRef<[u8]>) -> Result<()> ``` Non-breaking change that will enable data to be passed as value as well. Closes apache#9570 from Max-Meldrum/as_ref_patch Authored-by: Max Meldrum <max@meldrum.se> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds impl AsRef<[u8]> to the append_value/append of StringBuilder and BinaryBuilder.
Non-breaking change that will enable data to be passed as value as well.