ARROW-11795: [MATLAB] Migrate MATLAB Interface for Apache Arrow design doc to Markdown #9585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just checking in on the state of this pull request, I fully recognize that there is a large backlog of open requests and it must be a challenge to manage all the contributions. However, I wanted to ask if there is anything I can do to simplify the process for reviewers. I noticed that one of the CI checks failed, but I do not think it is related to the change in this request. Please let me know if there is any action I need to take. |
|
@lafiona If you could accept the change I proposed, CI should pass and I will merge this. Thanks for your patience. |
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
|
@nealrichardson Thank you for reviewing this and making the necessary change! I will add the Apache license header to all future files I submit. |
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
…n doc to Markdown Upload MATLAB Interface for Apache Arrow design document to `matlab/doc/` to be archived with the code. The discussion about the design document can be found here: https://lists.apache.org/thread.html/r7ac793613892487f60f080de0bc8bab6a27b3ae18e4c47b572e2649f%40%3Cdev.arrow.apache.org%3E **Note**: the design document contains a SVG image that is currently hosted in a separate repository (https://github.com/mathworks/matlab-arrow-support-files). It seems like it would be preferable to have this live directly within the Apache Arrow project, alongside the code, in `matlab/doc/images/`, however we are not sure if it is acceptable to commit an image file. The image is an SVG file which should be more amenable to version control (it is only 37 kb). Closes apache#9585 from lafiona/ARROW-11795 Lead-authored-by: Fiona La <fionala@mathworks.com> Co-authored-by: lafiona <fionala7@gmail.com> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 10, 2021
…n doc to Markdown Upload MATLAB Interface for Apache Arrow design document to `matlab/doc/` to be archived with the code. The discussion about the design document can be found here: https://lists.apache.org/thread.html/r7ac793613892487f60f080de0bc8bab6a27b3ae18e4c47b572e2649f%40%3Cdev.arrow.apache.org%3E **Note**: the design document contains a SVG image that is currently hosted in a separate repository (https://github.com/mathworks/matlab-arrow-support-files). It seems like it would be preferable to have this live directly within the Apache Arrow project, alongside the code, in `matlab/doc/images/`, however we are not sure if it is acceptable to commit an image file. The image is an SVG file which should be more amenable to version control (it is only 37 kb). Closes apache#9585 from lafiona/ARROW-11795 Lead-authored-by: Fiona La <fionala@mathworks.com> Co-authored-by: lafiona <fionala7@gmail.com> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
…n doc to Markdown Upload MATLAB Interface for Apache Arrow design document to `matlab/doc/` to be archived with the code. The discussion about the design document can be found here: https://lists.apache.org/thread.html/r7ac793613892487f60f080de0bc8bab6a27b3ae18e4c47b572e2649f%40%3Cdev.arrow.apache.org%3E **Note**: the design document contains a SVG image that is currently hosted in a separate repository (https://github.com/mathworks/matlab-arrow-support-files). It seems like it would be preferable to have this live directly within the Apache Arrow project, alongside the code, in `matlab/doc/images/`, however we are not sure if it is acceptable to commit an image file. The image is an SVG file which should be more amenable to version control (it is only 37 kb). Closes apache#9585 from lafiona/ARROW-11795 Lead-authored-by: Fiona La <fionala@mathworks.com> Co-authored-by: lafiona <fionala7@gmail.com> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upload MATLAB Interface for Apache Arrow design document to
matlab/doc/to be archived with the code.The discussion about the design document can be found here: https://lists.apache.org/thread.html/r7ac793613892487f60f080de0bc8bab6a27b3ae18e4c47b572e2649f%40%3Cdev.arrow.apache.org%3E
Note: the design document contains a SVG image that is currently hosted in a separate repository (https://github.com/mathworks/matlab-arrow-support-files). It seems like it would be preferable to have this live directly within the Apache Arrow project, alongside the code, in
matlab/doc/images/, however we are not sure if it is acceptable to commit an image file. The image is an SVG file which should be more amenable to version control (it is only 37 kb).