Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-12029: [R] Remove args from FeatherReader$create v2 #9757

Closed
wants to merge 5 commits into from

Conversation

pachadotdev
Copy link
Contributor

No description provided.

@pachadotdev pachadotdev changed the title Arrow 11912 ARROW-11912: [R] Remove args from FeatherReader$create Mar 19, 2021
@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@pachadotdev pachadotdev changed the title ARROW-11912: [R] Remove args from FeatherReader$create ARROW-12029: [R] Remove args from FeatherReader$create v2 Mar 19, 2021
@pachadotdev pachadotdev changed the title ARROW-12029: [R] Remove args from FeatherReader$create v2 aa Mar 19, 2021
@pachadotdev pachadotdev changed the title aa ARROW-12029: [R] Remove args from FeatherReader$create v2 Mar 19, 2021
@github-actions
Copy link

@jonkeane
Copy link
Member

I don't think that this will cause a conflict since you have the same change, but it looks like this branch has not been rebased on apache/arrow@master. I see this because https://github.com/apache/arrow/pull/9757/files#diff-3cda3c18dfe3014eabcb3854645f438184492bd1e9e4fc153439f01a609e74d0L209 has a change, but that change has already been merged. This might be a good time to practice rebasing since there aren't a large number of changes in this branch. Would you mind rebasing against the most recent commits in apache/arrow?

@pachadotdev
Copy link
Contributor Author

I don't think that this will cause a conflict since you have the same change, but it looks like this branch has not been rebased on apache/arrow@master. I see this because https://github.com/apache/arrow/pull/9757/files#diff-3cda3c18dfe3014eabcb3854645f438184492bd1e9e4fc153439f01a609e74d0L209 has a change, but that change has already been merged. This might be a good time to practice rebasing since there aren't a large number of changes in this branch. Would you mind rebasing against the most recent commits in apache/arrow?

thanks, I shall create a new PR since I added many files I didn't want to

@pachadotdev pachadotdev reopened this Mar 22, 2021
Copy link
Contributor

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also regenerate the Rd docs

r/R/feather.R Outdated Show resolved Hide resolved
Pachamaltese and others added 4 commits March 23, 2021 18:28
@pachadotdev pachadotdev deleted the ARROW-11912 branch April 5, 2021 15:45
GeorgeAp pushed a commit to sirensolutions/arrow that referenced this pull request Jun 7, 2021
Closes apache#9757 from pachamaltese/ARROW-11912

Lead-authored-by: Mauricio Vargas <mvargas@dcc.uchile.cl>
Co-authored-by: Pachamaltese <mvargas@dcc.uchile.cl>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
michalursa pushed a commit to michalursa/arrow that referenced this pull request Jun 13, 2021
Closes apache#9757 from pachamaltese/ARROW-11912

Lead-authored-by: Mauricio Vargas <mvargas@dcc.uchile.cl>
Co-authored-by: Pachamaltese <mvargas@dcc.uchile.cl>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants