Skip to content
Permalink
Browse files
[ASTERIXDB-3001][MVN] Grammarix not finding all productions
- user model changes: no
- storage format changes: no
- interface changes: no

Grammarix was mishandling the '"' case for quotes, making nearly
all productions after LiteralExpression not extensible.

Change-Id: Ib5d840237ee1224a4225cb67c795f3ac08452a76
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/14663
Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>
  • Loading branch information
glennga committed Jan 4, 2022
1 parent 5710394 commit dd27f0f1548257366ac2c995f7f6512ca9bc6478
Showing 1 changed file with 3 additions and 1 deletion.
@@ -459,7 +459,9 @@ private void readBlock(BufferedReader reader, char start, char end, Position pos
prevCharEscape = chars[bufferPosn] == ExternalDataConstants.ESCAPE;
}
} else {
if (chars[bufferPosn] == ExternalDataConstants.QUOTE) {
if (chars[bufferPosn] == ExternalDataConstants.QUOTE && chars[bufferPosn] != start
&& chars[bufferPosn - 1] != '\'') {
// If we see a quote that is not preceded by an apostrophe, then we are inside a string.
inString = true;
} else if (chars[bufferPosn] == start) {
depth += 1;

0 comments on commit dd27f0f

Please sign in to comment.