ATLAS-5306: Atlas React UI: SearchResult Table: Classification toolti…#665
Open
Brijesh619 wants to merge 1 commit into
Open
ATLAS-5306: Atlas React UI: SearchResult Table: Classification toolti…#665Brijesh619 wants to merge 1 commit into
Brijesh619 wants to merge 1 commit into
Conversation
…p is missing parent/super-type name
Contributor
Author
|
Contributor
Author
|
Contributor
Author
|
kevalbhatt
reviewed
Jun 9, 2026
|
|
||
| const getLabel = (label: string, optionalLabel?: string) => { | ||
| if (columnVal == "Classifications" || columnVal == "self") { | ||
| if (colName == "Classification") { |
Collaborator
There was a problem hiding this comment.
nit; better to use const or enum insted of string "Classification"
kevalbhatt
reviewed
Jun 9, 2026
| import { fetchGlossaryData } from "@redux/slice/glossarySlice"; | ||
|
|
||
| const CHIP_MAX_WIDTH = "200px"; | ||
| const CHIP_MAX_WIDTH = "100px"; |
kevalbhatt
reviewed
Jun 9, 2026
kevalbhatt
left a comment
kevalbhatt
left a comment
Collaborator
There was a problem hiding this comment.
found few nit and clean
kevalbhatt
reviewed
Jun 9, 2026
| className="tag-list" | ||
| style={{ flexWrap: isShowMoreLess ? "nowrap" : "wrap" }} | ||
| style={ | ||
| isShowMoreLess |
Collaborator
There was a problem hiding this comment.
why not to use https://mui.com/system/flexbox/?
inline style is not good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI & Layout Improvements (DialogShowMoreLess)
Chip Sizing & Truncation: Reduced the maximum chip width from 200px to 100px. Added proper text truncation (overflow: hidden, textOverflow: ellipsis, whiteSpace: nowrap) to ensure long text in chips is handled gracefully without overflowing boundaries.
Tag List Layout: Refactored the tag-list container to dynamically switch to a structured CSS Grid layout when isShowMoreLess is true, ensuring proper alignment of elements instead of relying purely on flex-wrapping.
Icon Alignment: Prevented the More Options and Add icons from shrinking when the container lacks space by adding flexShrink: 0 and optimizing padding.
Label Resolution: Updated the getLabel logic to appropriately reuse the checkSuperTypes utility for both "Classification" and "Propagated Classification" column types.
Toast Messaging: Improved the string formatting of the success toast message when a term/association is successfully removed.
Search Results Table (SearchResult)
Column Sizing: Explicitly defined a column size of 100 for both the Owner and Type columns in the Search Results table.
Table Wrapper: Wrapped the component in a new search-result-table-wrapper container to provide better structural styling control.
Code Cleanup: Refactored and cleaned up the class name interpolation for the entity Link component.