This repository has been archived by the owner. It is now read-only.
finally block may result in losing exception
jhsenjaliya pushed a commit to jhsenjaliya/eagle that referenced this pull request
Jul 12, 2017
… exception `return` inside `finally` block will result in losing exception: * If the finally block completes abruptly for reason S, then the try statement completes abruptly for reason S (and the throw of value V is discarded and forgotten). * If the finally block completes abruptly for reason S, then the try statement completes abruptly for reason S (and reason R is discarded). reference: http://docs.oracle.com/javase/specs/jls/se8/html/jls-14.html#jls-14.20.2 https://issues.apache.org/jira/secure/attachment/12863778/FinallyTest.java (https://issues.apache.org/jira/browse/EAGLE-1009) Author: asdf2014 <firstname.lastname@example.org> Closes apache#920 from asdf2014/return_inside_finally.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.