Skip to content
This repository has been archived by the owner. It is now read-only.

[MINOR] Fxi sprk/egle issues in JPM module #943

Closed
wants to merge 1 commit into from
Closed

[MINOR] Fxi sprk/egle issues in JPM module #943

wants to merge 1 commit into from

Conversation

@asdf2014
Copy link
Member

@asdf2014 asdf2014 commented Jun 7, 2017

Fxi sprk issues in JPM module

@asdf2014 asdf2014 changed the title [MINOR] Fxi sprk issues in JPM module [MINOR] Fxi sprk/egle issues in JPM module Jun 7, 2017
@qingwen220
Copy link
Contributor

@qingwen220 qingwen220 commented Jun 7, 2017

@asdf2014 I do not think these are big issues.

On the other hand, this changes will have a big impact for users who have already installed these features. (old data are missing).

@asdf2014
Copy link
Member Author

@asdf2014 asdf2014 commented Jun 7, 2017

@qingwen220 Yep, you are right. This will destroy backward compatibility. But, for people with obsessive compulsive disorder it still be a huge problem. Moreover, if you do not modify it now, then want to modify in future, it will become more difficult.

@jhsenjaliya
Copy link
Contributor

@jhsenjaliya jhsenjaliya commented Jun 8, 2017

@asdf2014 i know how it feels.
but as @qingwen220 pointed out, it will be too much work to make this compatible for people already running on branch 0.5
how about we take up this on next version 0.6 ? which is master after the master version changes.

@asdf2014
Copy link
Member Author

@asdf2014 asdf2014 commented Jun 9, 2017

@jhsenjaliya Okay, i see :D

@asdf2014 asdf2014 closed this Nov 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants