This repository has been archived by the owner. It is now read-only.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Fix cron id collision bug by avoiding state in Quartz jobs"
This reverts commit e2ea191. A bug was found where jobs that were killed via the KILL_EXISTING flag would set `path` as `null` in `JobDataMap` that would block concurrent runs, but that value would never be set to `key` after the the delayed run finished because it would run outside of the `Job` execution. The issue in https://reviews.apache.org/r/65680/ will occur again, but it is rare and has been around for a few years. This bug was not caught in the unit test `testKillExisting` because `executeWithReplay` is mocked and runs synchronously within the `Job` execution, allowing the `key` to be persisted. Reviewed at https://reviews.apache.org/r/65810/
- Loading branch information
Showing 2 changed files with 11 additions and 15 deletions.