Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-3701: Add github action to validate maven 4 build compatibility #2036

Merged
merged 2 commits into from
Jan 5, 2023

Conversation

iemejia
Copy link
Member

@iemejia iemejia commented Dec 26, 2022

What is the purpose of the change

(For example: This pull request improves file read performance by buffering data, fixing AVRO-XXXX.)

Verifying this change

(Please pick one of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Extended interop tests to verify consistent valid schema names between SDKs
  • Added test that validates that Java throws an AvroRuntimeException on invalid binary data
  • Manually verified the change by building the website and checking the new redirect

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the build label Dec 26, 2022
@iemejia iemejia force-pushed the maven4-githubactions branch 2 times, most recently from 34385ab to 72cc630 Compare December 26, 2022 12:30
@iemejia iemejia changed the title [WIP] Add github action to validate maven 4 build compatibility [AVRO-3701] Add github action to validate maven 4 build compatibility Jan 5, 2023
@iemejia iemejia merged commit 0dcb351 into apache:master Jan 5, 2023
@iemejia
Copy link
Member Author

iemejia commented Jan 5, 2023

Thanks @martin-g for the quick review!

@iemejia iemejia deleted the maven4-githubactions branch January 5, 2023 20:01
@iemejia iemejia changed the title [AVRO-3701] Add github action to validate maven 4 build compatibility AVRO-3701: Add github action to validate maven 4 build compatibility Jan 5, 2023
@iemejia
Copy link
Member Author

iemejia commented Jan 5, 2023

Argh just discovered that I badly renamed the commit title to [AVRO-XXXX] instead of AVRO-XXXX: Sorry

RyanSkraba pushed a commit to RyanSkraba/avro that referenced this pull request Jun 13, 2023
…apache#2036)

* Bump Apache Parent POM to version 29

* Add github action to validate maven 4 build compatibility
RyanSkraba pushed a commit that referenced this pull request Jun 14, 2023
…#2036)

* Bump Apache Parent POM to version 29

* Add github action to validate maven 4 build compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants