AVRO-3722 [ruby] Eagerly Initialize Instance Variables in Ruby Implementation #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit eagerly initializes the `@type_adapter` instance variable to `nil` so that implementations can see better inline cache hits
tjwp
approved these changes
Mar 8, 2023
tjwp
pushed a commit
that referenced
this pull request
Mar 8, 2023
…line cache hits (#2132) Eagerly initialize the `@type_adapter` instance variable to `nil` to see better inline cache hits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit eagerly initializes the
@type_adapterinstance variable tonilso that implementations can see better inline cache hitsWhat is the purpose of the change
Improving inline cache performance with the Ruby AVRO gem.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Here is the JIRA ticket
Thanks!