AVRO-4269: [Java] Fix timestamp-nanos conversion before epoch#3813
Open
emarussoo wants to merge 1 commit into
Open
AVRO-4269: [Java] Fix timestamp-nanos conversion before epoch#3813emarussoo wants to merge 1 commit into
emarussoo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fixes
TimestampNanosConversion.toLongforInstantvalues before the Unix epoch with a positive nanosecond component.The affected code path handles cases where
seconds < 0andnanos > 0. In that branch, the implementation needs to adjust the positive nanosecond component relative to the previous epoch second.The previous implementation subtracted
1_000_000, which is a microsecond-scale constant. Since this conversion handles thetimestamp-nanoslogical type, the adjustment must subtract1_000_000_000L, the number of nanoseconds in one second.For example,
1969-12-31T23:59:59.999999999Zis one nanosecond before the Unix epoch and should convert to-1L. Before this fix, it converted to998999999L.This PR updates the adjustment constant and adds a regression test for the affected pre-epoch nanos case.
Fixes: AVRO-4269
Verifying this change
This change adds a regression test for timestamp-nanos conversion before the epoch.
This change added tests and can be verified as follows:
mvn -Dtest=TestTimeConversions#timestampNanosConversionBeforeEpochWithPositiveNanos testmvn -Dtest=TestTimeConversions testDocumentation