Skip to content

AVRO-2780: ProtobufData and ThriftData Can Get Into Endless Loop#908

Merged
Fokko merged 1 commit into
apache:masterfrom
belugabehr:AVRO-2780
Jun 8, 2020
Merged

AVRO-2780: ProtobufData and ThriftData Can Get Into Endless Loop#908
Fokko merged 1 commit into
apache:masterfrom
belugabehr:AVRO-2780

Conversation

@belugabehr
Copy link
Copy Markdown
Contributor

@belugabehr belugabehr commented Jun 3, 2020

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@probot-autolabeler probot-autolabeler Bot added the Java Pull Requests for Java binding label Jun 3, 2020
Copy link
Copy Markdown
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, thanks @belugabehr

@Fokko Fokko merged commit 249db48 into apache:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Java Pull Requests for Java binding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants