Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-8661] Moving other modules to have per-module loggers #10100

Merged
merged 3 commits into from Nov 15, 2019

Conversation

@pabloem
Copy link
Member

pabloem commented Nov 14, 2019

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@pabloem pabloem force-pushed the pabloem:logger-for-others branch from 8ad8ff2 to ccb6af2 Nov 14, 2019
@pabloem

This comment has been minimized.

Copy link
Member Author

pabloem commented Nov 14, 2019

r: @robertwb
this should be the simplest of the prs to switch to logging on per-module loggers

@lukecwik lukecwik merged commit db11e06 into apache:master Nov 15, 2019
5 checks passed
5 checks passed
Portable_Python ("Run Portable_Python PreCommit") SUCCESS
Details
Python ("Run Python PreCommit") SUCCESS
Details
Python2_PVR_Flink ("Run Python2_PVR_Flink PreCommit") SUCCESS
Details
PythonLint ("Run PythonLint PreCommit") SUCCESS
Details
RAT ("Run RAT PreCommit") SUCCESS
Details
@pabloem pabloem deleted the pabloem:logger-for-others branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.