Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-8670] Manage environment parallelism in DefaultJobBundleFactory #10124

Merged
merged 1 commit into from Nov 16, 2019

Conversation

@tweise
Copy link
Contributor

tweise commented Nov 15, 2019

Move handling of parallel environments to DefaultJobBundleFactory in preparation of adding a different scheduling option.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@tweise tweise force-pushed the tweise:BEAM-8670.environmentParallelism branch from 0d3bb4e to 67dcc47 Nov 15, 2019
@tweise tweise requested review from ibzib, lukecwik and mxm Nov 15, 2019
@mxm
mxm approved these changes Nov 15, 2019
@@ -145,8 +150,23 @@ private static int getEnvironmentExpirationMillis(JobInfo jobInfo) {
return pipelineOptions.as(PortablePipelineOptions.class).getEnvironmentExpirationMillis();
}

private LoadingCache<Environment, WrappedSdkHarnessClient> createEnvironmentCache(
ThrowingFunction<ServerFactory, ServerInfo> serverInfoCreator) {
private static int getMaxEnvironments(JobInfo jobInfo) {

This comment has been minimized.

Copy link
@mxm

mxm Nov 15, 2019

Contributor

Move this down to after the non-static methods?

This comment has been minimized.

Copy link
@mxm

mxm Nov 15, 2019

Contributor
Suggested change
private static int getMaxEnvironments(JobInfo jobInfo) {
private static int getMaxEnvironmentClients(JobInfo jobInfo) {
}
});

ImmutableList.Builder caches = ImmutableList.builder();

This comment has been minimized.

Copy link
@mxm

mxm Nov 15, 2019

Contributor
Suggested change
ImmutableList.Builder caches = ImmutableList.builder();
ImmutableList.Builder<LoadingCache<Environment, WrappedSdkHarnessClient>> caches = ImmutableList.<>builder();
environmentFactoryProviderMap,
stageIdGenerator,
serverInfo)) {
for (int i = 0; i < expectedParallelism + 5; i++) {

This comment has been minimized.

Copy link
@mxm

mxm Nov 15, 2019

Contributor

Why +5?

@tweise

This comment has been minimized.

Copy link
Contributor Author

tweise commented Nov 15, 2019

@tweise tweise force-pushed the tweise:BEAM-8670.environmentParallelism branch from 67dcc47 to 45dc280 Nov 15, 2019
@tweise

This comment has been minimized.

Copy link
Contributor Author

tweise commented Nov 15, 2019

11:10:47 Execution failed for task ':sdks:java:io:rabbitmq:test'.
11:10:47 > Process 'Gradle Test Executor 111' finished with non-zero exit value 143
@tweise

This comment has been minimized.

Copy link
Contributor Author

tweise commented Nov 15, 2019

Run Java PreCommit

@tweise tweise merged commit 1386b94 into apache:master Nov 16, 2019
5 checks passed
5 checks passed
Java ("Run Java PreCommit") SUCCESS
Details
Portable_Python ("Run Portable_Python PreCommit") SUCCESS
Details
Python2_PVR_Flink ("Run Python2_PVR_Flink PreCommit") SUCCESS
Details
RAT ("Run RAT PreCommit") SUCCESS
Details
Spotless ("Run Spotless PreCommit") SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.