Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.17.0][BEAM-8917][BEAM-8967] jsr305 dependency declaration for Nullable class (#10324) #10370

Merged
merged 2 commits into from Dec 17, 2019

Conversation

iemejia
Copy link
Member

@iemejia iemejia commented Dec 12, 2019

…10324)

The Maven artifact org.apache.beam:beam-sdks-java-core, which contains org.apache.beam.sdk.schemas.FieldValueTypeInformation, should declare the dependency to com.google.code.findbugs:jsr305. The class needs Nullable class at runtime.
@iemejia iemejia requested a review from Ardagan December 12, 2019 22:33
@Ardagan
Copy link
Contributor

Ardagan commented Dec 12, 2019

Run SQL postcommit

@Ardagan
Copy link
Contributor

Ardagan commented Dec 12, 2019

Hi Ismael,
Should I start building RC after this pr goes in, or will there be more changes required?

@iemejia
Copy link
Member Author

iemejia commented Dec 13, 2019

Yes you can go ahead once this one is in. Nothing else is missing AFAIK. Thanks @Ardagan !

@iemejia
Copy link
Member Author

iemejia commented Dec 16, 2019

Oups we discovered one minor issue I will cherry-pick an extra commit here and then it is ok to go. For more details https://issues.apache.org/jira/browse/BEAM-8967

@iemejia iemejia changed the title [release-2.17.0][BEAM-8917] jsr305 dependency declaration for Nullable class (#10324) [release-2.17.0][BEAM-8917][BEAM-8967] jsr305 dependency declaration for Nullable class (#10324) Dec 16, 2019
@iemejia
Copy link
Member Author

iemejia commented Dec 16, 2019

Run SQL postcommit

@Ardagan
Copy link
Contributor

Ardagan commented Dec 16, 2019

run python precommit

1 similar comment
@Ardagan
Copy link
Contributor

Ardagan commented Dec 16, 2019

run python precommit

@aaltay
Copy link
Member

aaltay commented Dec 17, 2019

I suggest merging this. The change is unrelated to python and it is blocking the RC.

@Ardagan Ardagan merged commit 5e3c975 into apache:release-2.17.0 Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants