Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-9654] Update Jet Runner to Jet version 4.0 #11273

Merged
merged 3 commits into from Apr 1, 2020

Conversation

jbartok
Copy link

@jbartok jbartok commented Mar 31, 2020

Hazelcast Jet recently released version 4.0 (https://jet-start.sh/blog/2020/03/02/jet-40-is-released) and this pull request updates Beam's Jet Runner to that version. It also extends the Runners web page with information about the 4.0 version.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@jbartok
Copy link
Author

jbartok commented Mar 31, 2020

R: @mxm

Copy link
Contributor

@mxm mxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jbartok. LGTM.

@mxm
Copy link
Contributor

mxm commented Mar 31, 2020

Btw, there doesn't appear to be a Jenkins job (see .test-infra) for running the validates runner or other integration tests. Do you plan to add one?

@jbartok
Copy link
Author

jbartok commented Apr 1, 2020

Btw, there doesn't appear to be a Jenkins job (see .test-infra) for running the validates runner or other integration tests. Do you plan to add one?

I don't plan to add one, because I'm completely unfamiliar with the whole topic. I do have some Gradle targets in the Jet Runner module to execute @ValidatesRunner & @NeedsRunner tests with it, but that's it. I did check those, just as many pass now as before the upgrade.

@mxm
Copy link
Contributor

mxm commented Apr 1, 2020

I think it would be helpful to compare the jet runner with other runners. If there is already a Gradle target, it is very easy to do. The Jenkins job dsl scripts in .test-infra/jenkins automatically create the Jenkins job. You can see how they work if you just look at the ones for Flink or other runners.

@mxm mxm merged commit cf7ca7c into apache:master Apr 1, 2020
@mxm
Copy link
Contributor

mxm commented Apr 1, 2020

Btw, the JIRA is missing, I've created it here: https://jira.apache.org/jira/browse/BEAM-9654

@jbartok jbartok changed the title Update Jet Runner to Jet version 4.0 [BEAM-9654] Update Jet Runner to Jet version 4.0 Apr 1, 2020
@jbartok
Copy link
Author

jbartok commented Apr 1, 2020

Question: the runner's page (https://beam.apache.org/documentation/runners/jet/) has an "Adapt for" button, to change content between Jet 3.0 and Jet 4.0. It worked perfectly in a locally served website, but looks like it doesn't in the deployed one.... Any idea why?

@jbartok jbartok deleted the update-jet-runner branch April 1, 2020 09:12
@jbartok
Copy link
Author

jbartok commented Apr 1, 2020

Yeah, works in the merged in version too, locally, but what ended up deployed is broken... No idea why.

@mxm
Copy link
Contributor

mxm commented Apr 1, 2020

Works for me.

@jbartok
Copy link
Author

jbartok commented Apr 1, 2020

Yeah, now that I've flushed my browser cash works indeed... Thanks for checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants