New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-9654] Update Jet Runner to Jet version 4.0 #11273
Conversation
R: @mxm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jbartok. LGTM.
Btw, there doesn't appear to be a Jenkins job (see .test-infra) for running the validates runner or other integration tests. Do you plan to add one? |
I don't plan to add one, because I'm completely unfamiliar with the whole topic. I do have some Gradle targets in the Jet Runner module to execute @ValidatesRunner & @NeedsRunner tests with it, but that's it. I did check those, just as many pass now as before the upgrade. |
I think it would be helpful to compare the jet runner with other runners. If there is already a Gradle target, it is very easy to do. The Jenkins job dsl scripts in |
Btw, the JIRA is missing, I've created it here: https://jira.apache.org/jira/browse/BEAM-9654 |
Question: the runner's page (https://beam.apache.org/documentation/runners/jet/) has an "Adapt for" button, to change content between Jet 3.0 and Jet 4.0. It worked perfectly in a locally served website, but looks like it doesn't in the deployed one.... Any idea why? |
Yeah, works in the merged in version too, locally, but what ended up deployed is broken... No idea why. |
Works for me. |
Yeah, now that I've flushed my browser cash works indeed... Thanks for checking. |
Hazelcast Jet recently released version 4.0 (https://jet-start.sh/blog/2020/03/02/jet-40-is-released) and this pull request updates Beam's Jet Runner to that version. It also extends the Runners web page with information about the 4.0 version.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.