Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-10052] check hash and avoid duplicated artifacts #11771

Merged
merged 1 commit into from May 21, 2020

Conversation

ihji
Copy link
Contributor

@ihji ihji commented May 21, 2020


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@ihji
Copy link
Contributor Author

ihji commented May 21, 2020

R: @chamikaramj

@chamikaramj
Copy link
Contributor

WDYT about ihji#1 ?
(only change is to Environments.java other changes should go away if you rebase)

@ihji
Copy link
Contributor Author

ihji commented May 21, 2020

WDYT about ihji#1 ?
(only change is to Environments.java other changes should go away if you rebase)

It will add 36 characters + the length of file name. Is there any concern about the maximum length of GCS object name? I think it's okay if GCS allows enough space in object names.

@chamikaramj
Copy link
Contributor

Seems like GCS allows object names up to 1024 bytes - https://cloud.google.com/storage/docs/naming-objects

Agree that it might be good to limit the size of uploaded jars given that we are picking all jars from class path. Possibly we should try to send the actual name along with the artifact proto but that can separate.

@chamikaramj
Copy link
Contributor

LGTM

@chamikaramj
Copy link
Contributor

Retest this please

3 similar comments
@chamikaramj
Copy link
Contributor

Retest this please

@chamikaramj
Copy link
Contributor

Retest this please

@chamikaramj
Copy link
Contributor

Retest this please

@chamikaramj chamikaramj merged commit 7cc1a7d into apache:master May 21, 2020
@ihji ihji deleted the BEAM-10052 branch March 30, 2021 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants