New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-10381] Increase retries in pull_licenses_java.py from 3 to 9. #12130
Conversation
R: @aaltay |
@@ -39,7 +39,7 @@ | |||
from urllib.request import urlopen, URLError, HTTPError | |||
|
|||
SOURCE_CODE_REQUIRED_LICENSES = ['lgpl', 'glp', 'cddl', 'mpl'] | |||
RETRY_NUM = 3 | |||
RETRY_NUM = 9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an exponential weight on L47. With 9 retries it will wait for a long time. I do not know what is the multiplier, but even with a multiplier of 1, this will be almost 10 minutes wait before the last retry.
Should we change retry number? Or the exponential multiplier?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we use wait_fixed(5) instead of the wait_exponential. Since we were only setting retries to 3 before it should have been waiting:
2s, 4s, 8s.
wait_fixed(5) will spend about a minute max on each url. I don't want to make it wait much more. I believe the test will time out if we make it too long.
wait: 5s, 5s, 5s, 5s, 5s, 5s, 5s, 5s, 5s
I suggest we try this first. WDYT? Here are the tenacity docs:
https://tenacity.readthedocs.io/en/latest/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.
Run Java PreCommit |
retest this please |
1 similar comment
retest this please |
[BEAM-10381] Increase retries in pull_licenses_java.py from 3 to 9.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.