Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-10381] Increase retries in pull_licenses_java.py from 3 to 9. #12130

Merged
merged 1 commit into from Jun 30, 2020

Conversation

ajamato
Copy link

@ajamato ajamato commented Jun 30, 2020

[BEAM-10381] Increase retries in pull_licenses_java.py from 3 to 9.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang --- --- Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@ajamato
Copy link
Author

ajamato commented Jun 30, 2020

R: @aaltay

@@ -39,7 +39,7 @@
from urllib.request import urlopen, URLError, HTTPError

SOURCE_CODE_REQUIRED_LICENSES = ['lgpl', 'glp', 'cddl', 'mpl']
RETRY_NUM = 3
RETRY_NUM = 9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an exponential weight on L47. With 9 retries it will wait for a long time. I do not know what is the multiplier, but even with a multiplier of 1, this will be almost 10 minutes wait before the last retry.

Should we change retry number? Or the exponential multiplier?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we use wait_fixed(5) instead of the wait_exponential. Since we were only setting retries to 3 before it should have been waiting:
2s, 4s, 8s.

wait_fixed(5) will spend about a minute max on each url. I don't want to make it wait much more. I believe the test will time out if we make it too long.
wait: 5s, 5s, 5s, 5s, 5s, 5s, 5s, 5s, 5s

I suggest we try this first. WDYT? Here are the tenacity docs:
https://tenacity.readthedocs.io/en/latest/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

@ajamato
Copy link
Author

ajamato commented Jun 30, 2020

Run Java PreCommit

@aaltay
Copy link
Member

aaltay commented Jun 30, 2020

retest this please

1 similar comment
@aaltay
Copy link
Member

aaltay commented Jun 30, 2020

retest this please

@aaltay aaltay merged commit 688ed5c into apache:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants