[BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum … #12817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @angoenka |
angoenka
reviewed
Sep 10, 2020
| # distribution metric is not meant to use on large values, but in case | ||
| # it is, the value can overflow and become double_value, the correctness | ||
| # of the value may not be guaranteed. | ||
| dist_sum = int( |
There was a problem hiding this comment.
Do we need to log if this happens else this will be a silent failure.
There was a problem hiding this comment.
Should we also add the metric name in the logs for easier debugging.
Codecov Report
@@ Coverage Diff @@
## master #12817 +/- ##
===========================================
+ Coverage 40.38% 82.39% +42.00%
===========================================
Files 451 451
Lines 53721 53769 +48
===========================================
+ Hits 21696 44301 +22605
+ Misses 32025 9468 -22557
Continue to review full report at Codecov.
|
ibzib
pushed a commit
to ibzib/beam
that referenced
this pull request
Sep 30, 2020
apache#12817) * [BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum overflows * Add logging * Add the distribution counter to logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…overflows
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.