Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on mpyp checks for filesystem #14425

Merged
merged 2 commits into from Apr 8, 2021
Merged

Turn on mpyp checks for filesystem #14425

merged 2 commits into from Apr 8, 2021

Conversation

abergmeier
Copy link
Contributor

@abergmeier abergmeier commented Apr 3, 2021

  • Needs some explicit asserts
  • Use BinaryIO.closed as property

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK ULR Dataflow Flink Samza Spark Twister2
Go --- --- Build Status --- Build Status ---
Java Build Status Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status --- Build Status Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

- Needs some explicit asserts
- Use BinaryIO.closed as property
@abergmeier
Copy link
Contributor Author

R: @pabloem

@pabloem
Copy link
Member

pabloem commented Apr 8, 2021

Run Python PreCommit

@pabloem pabloem self-requested a review April 8, 2021 17:48
@pabloem
Copy link
Member

pabloem commented Apr 8, 2021

LGTM! Thanks @abergmeier

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #14425 (9d22d4b) into master (bee495f) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14425      +/-   ##
==========================================
+ Coverage   83.45%   83.48%   +0.02%     
==========================================
  Files         463      447      -16     
  Lines       59013    58883     -130     
==========================================
- Hits        49252    49158      -94     
+ Misses       9761     9725      -36     
Impacted Files Coverage Δ
...beam/portability/api/beam_artifact_api_pb2_grpc.py
...am/examples/complete/juliaset/juliaset/__init__.py
.../srcs/sdks/python/apache_beam/coders/observable.py
...s/python/apache_beam/examples/wordcount_minimal.py
...beam/testing/load_tests/load_test_metrics_utils.py
.../srcs/sdks/python/apache_beam/utils/proto_utils.py
...cs/sdks/python/apache_beam/typehints/decorators.py
.../sdks/python/apache_beam/examples/snippets/util.py
...sdks/python/apache_beam/internal/metrics/metric.py
...d/srcs/sdks/python/apache_beam/transforms/stats.py
... and 900 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bee495f...9d22d4b. Read the comment docs.

@pabloem pabloem merged commit b5a8b54 into apache:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants