[BEAM-13236] Properly close kinesis producer on teardown

[mosche]

Adds a missing producer.destroy() to KinesisWriterFn.teardown() .
Also, remove obsolete bugfix that is fixed in recent versions of KPL. See awslabs/amazon-kinesis-producer#34 (comment)

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Choose reviewer(s) and mention them in a comment (R: @username).
• Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang	ULR	Dataflow	Flink	Samza	Spark	Twister2
Go	---					---
Java
Python	---					---
XLang						---

Examples testing status on various runners

Lang	ULR	Dataflow	Flink	Samza	Spark	Twister2
Go	---	---	---	---	---	---	---
Java	---		---	---	---	---	---
Python	---	---	---	---	---	---	---
XLang	---	---	---	---	---	---	---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go	Java	Python

Pre-Commit Tests Status (on master branch)

---	Java	Python	Go	Website	Whitespace	Typescript
Non-portable
Portable	---			---	---	---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

[mosche]

Run Java PreCommit

[mosche]

R: @aromanenko-dev
Just a small adhoc fix

[aromanenko-dev]

Run Java PostCommit

[aromanenko-dev]

LGTM.
@mosche Could you create a new Jira for this fix and update commit message accordingly? Thanks

[mosche]

@aromanenko-dev done 👍

[mosche]

@echauchot Could you take over and merge?

[mosche]

Actually, this is more complicated than I thought. Closing the PR for now.

Per JVM a producer is shared among all KinesisWriterFns. Sharing producers absolutely makes sense, nevertheless this absolutely leaks. On teardown the shared(!) producer reference is unset, though it might still be required by another unfinished bundle running on the same JVM.

Also, if the static instance is reused, producer properties might be silently dropped without notice.

      private static transient IKinesisProducer producer;

[echauchot]

@mosche yes no problem, ping me on the new PR I'll do a quick review and merge if @aromanenko-dev is unavailable

[mosche]

I've fixed initialisation and teardown of the Kinesis producer taking into account that one single producer (daemon) is shared among all writer instances of the same JVM.

[echauchot]

thanks for this fix @mosche ! Reviewing ...

[echauchot]

Thanks for your work @mosche ! And very good catch ! Only some minor changes but mostly LGTM

[adude3141]

LGTM.

[aromanenko-dev]

Seems that this PR is ready for merge or something is left to do?

[mosche]

yes @aromanenko-dev, that's ready 👍

[echauchot]

thanks @aromanenko-dev for merging. I did not have time to give the final LGTM and merge

[adude3141]

thx @aromanenko-dev for doing the merge here!