From 0d0eb9bf3fa5b3facf403d486787c579c2e82228 Mon Sep 17 00:00:00 2001
From: Dan Halperin <dhalperi@google.com>
Date: Tue, 24 Jan 2017 13:52:06 -0800
Subject: [PATCH] [BEAM-246] re-enable Checkstyle by default

This adds 50%+ overhead to a clean build (with testing disabled), but
per dev@ discussion is a huge usability win for contributors and
committers alike.

https://lists.apache.org/thread.html/CAA8k_FKafuon8GEA3CXwR2MZh2kAXEFZQK=BgX5tk2fZJebrag@mail.gmail.com
---
 examples/pom.xml | 14 +++++++++-----
 runners/pom.xml  | 14 +++++++++-----
 sdks/pom.xml     | 13 +++++++------
 3 files changed, 25 insertions(+), 16 deletions(-)

diff --git a/examples/pom.xml b/examples/pom.xml
index adfbaa97e347..4294c2d2dd9c 100644
--- a/examples/pom.xml
+++ b/examples/pom.xml
@@ -50,11 +50,6 @@
       <id>release</id>
       <build>
         <plugins>
-          <plugin>
-            <groupId>org.apache.maven.plugins</groupId>
-            <artifactId>maven-checkstyle-plugin</artifactId>
-          </plugin>
-
           <plugin>
             <groupId>org.codehaus.mojo</groupId>
             <artifactId>findbugs-maven-plugin</artifactId>
@@ -64,4 +59,13 @@
     </profile>
   </profiles>
 
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-checkstyle-plugin</artifactId>
+      </plugin>
+    </plugins>
+  </build>
+
 </project>
diff --git a/runners/pom.xml b/runners/pom.xml
index fb84164b266b..ceaedfe8c29c 100644
--- a/runners/pom.xml
+++ b/runners/pom.xml
@@ -46,11 +46,6 @@
       <id>release</id>
       <build>
         <plugins>
-          <plugin>
-            <groupId>org.apache.maven.plugins</groupId>
-            <artifactId>maven-checkstyle-plugin</artifactId>
-          </plugin>
-
           <plugin>
             <groupId>org.codehaus.mojo</groupId>
             <artifactId>findbugs-maven-plugin</artifactId>
@@ -99,4 +94,13 @@
       </build>
     </profile>
   </profiles>
+
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-checkstyle-plugin</artifactId>
+      </plugin>
+    </plugins>
+  </build>
 </project>
diff --git a/sdks/pom.xml b/sdks/pom.xml
index bfdfcd9d6be6..268272801b42 100644
--- a/sdks/pom.xml
+++ b/sdks/pom.xml
@@ -41,11 +41,6 @@
       <id>release</id>
       <build>
         <plugins>
-          <plugin>
-            <groupId>org.apache.maven.plugins</groupId>
-            <artifactId>maven-checkstyle-plugin</artifactId>
-          </plugin>
-
           <plugin>
             <groupId>org.codehaus.mojo</groupId>
             <artifactId>findbugs-maven-plugin</artifactId>
@@ -58,7 +53,6 @@
   <build>
     <pluginManagement>
       <plugins>
-
         <!-- SDKs will generally offer test suites for runners, as sdks/java does. -->
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
@@ -74,6 +68,13 @@
         </plugin>
       </plugins>
     </pluginManagement>
+
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-checkstyle-plugin</artifactId>
+      </plugin>
+    </plugins>
   </build>
 
 </project>