[BEAM-886] Rename DoFn to OldDoFn and add deprecation message #1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refer to this link for build results (access rights to CI server needed): Build result: FAILURE[...truncated 9868 lines...] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745)Caused by: org.apache.maven.plugin.MojoExecutionException: Command execution failed. at org.codehaus.mojo.exec.ExecMojo.execute(ExecMojo.java:276) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) ... 31 moreCaused by: org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1) at org.apache.commons.exec.DefaultExecutor.executeInternal(DefaultExecutor.java:404) at org.apache.commons.exec.DefaultExecutor.execute(DefaultExecutor.java:166) at org.codehaus.mojo.exec.ExecMojo.executeCommandLine(ExecMojo.java:660) at org.codehaus.mojo.exec.ExecMojo.execute(ExecMojo.java:265) ... 33 more2017-02-02T03:32:07.692 [ERROR] 2017-02-02T03:32:07.692 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-02-02T03:32:07.692 [ERROR] 2017-02-02T03:32:07.692 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-02-02T03:32:07.692 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException2017-02-02T03:32:07.693 [ERROR] 2017-02-02T03:32:07.693 [ERROR] After correcting the problems, you can resume the build with the command2017-02-02T03:32:07.693 [ERROR] mvn -rf :beam-sdks-pythonchannel stoppedSetting status of fcca354 to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/6999/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install--none-- |
sb2nov
changed the title
sb2nov
force-pushed
the
BEAM-deprecate-oldDoFn
branch
from
fcca354
to
c070dc6
Compare
sb2nov
changed the title
|
R: @aaltay PTAL |
aaltay
reviewed
Feb 3, 2017
| @@ -228,6 +229,10 @@ class DoFn(WithTypeHints, HasDisplayData): | |||
| callable object using the CallableWrapperDoFn class. | |||
| """ | |||
|
|
|||
| def __init__(self): | |||
| logging.warning('Use of OldDoFn is deprecated please use DoFn instead') | |||
sb2nov
changed the title
sb2nov
force-pushed
the
BEAM-deprecate-oldDoFn
branch
from
c070dc6
to
dd3280c
Compare
|
LGTM. waiting for tests. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @aaltay PTAL
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.