Revise error message to state the actual size limit #26754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Apache Beam tries to insert a BigQuery row that is between 9 to 10 MB in size, the following error occurs and confuses users with size limit information. "Error message from worker: java.lang.RuntimeException: We have observed a row that is 9641699 bytes in size. BigQuery supports request sizes up to 10MB, and this row is too large. You may change your retry strategy to unblock this pipeline, and the row will be output as a failed insert." Updating the error message to display the actual size limit.
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @bvolpato for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
…ssage Revised test to address the following error message change: Old Message: "We have observed a row that is 9446414 bytes in size. BigQuery supports request sizes up to 10MB, and this row is too large. You may change your retry strategy to unblock this pipeline, and the row will be output as a failed insert." New Message: "We have observed a row that is 9446414 bytes in size and exceeded BigQueryIO limit of 9MB. While BigQuery supports request sizes up to 10MB, BigQueryIO sets the limit at 9MB to leave room for request overhead. You may change your retry strategy to unblock this pipeline, and the row will be output as a failed insert."
johnjcasey
approved these changes
May 19, 2023
bvolpato
approved these changes
May 20, 2023
Contributor
|
Reminder, please take a look at this pr: @bvolpato @johnjcasey |
cushon
pushed a commit
to cushon/beam
that referenced
this pull request
May 24, 2024
* Revise error message to state the actual size limit When Apache Beam tries to insert a BigQuery row that is between 9 to 10 MB in size, the following error occurs and confuses users with size limit information. "Error message from worker: java.lang.RuntimeException: We have observed a row that is 9641699 bytes in size. BigQuery supports request sizes up to 10MB, and this row is too large. You may change your retry strategy to unblock this pipeline, and the row will be output as a failed insert." Updating the error message to display the actual size limit. * Update BigQueryServicesImplTest.java to test against revised error message Revised test to address the following error message change: Old Message: "We have observed a row that is 9446414 bytes in size. BigQuery supports request sizes up to 10MB, and this row is too large. You may change your retry strategy to unblock this pipeline, and the row will be output as a failed insert." New Message: "We have observed a row that is 9446414 bytes in size and exceeded BigQueryIO limit of 9MB. While BigQuery supports request sizes up to 10MB, BigQueryIO sets the limit at 9MB to leave room for request overhead. You may change your retry strategy to unblock this pipeline, and the row will be output as a failed insert."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Apache Beam tries to insert a BigQuery row that is between 9 to 10 MB in size, the following error occurs and confuses users with size limit information.
"Error message from worker: java.lang.RuntimeException: We have observed a row that is 9641699 bytes in size. BigQuery supports request sizes up to 10MB, and this row is too large. You may change your retry strategy to unblock this pipeline, and the row will be output as a failed insert."
Updating the error message to display the actual size limit.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.