From c909c9efe97632a9a9ab19ca6a6d99f3c8c5ffe0 Mon Sep 17 00:00:00 2001 From: eralmas7 Date: Sun, 9 Jul 2017 11:50:52 +0530 Subject: [PATCH 1/3] BEAM-934 Fixed build by fixing firebug error. --- .../apache/beam/examples/complete/game/injector/Injector.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/java8/src/main/java/org/apache/beam/examples/complete/game/injector/Injector.java b/examples/java8/src/main/java/org/apache/beam/examples/complete/game/injector/Injector.java index b9a3ff23f77b..d9667ad8cadc 100644 --- a/examples/java8/src/main/java/org/apache/beam/examples/complete/game/injector/Injector.java +++ b/examples/java8/src/main/java/org/apache/beam/examples/complete/game/injector/Injector.java @@ -167,7 +167,7 @@ long getStartTimeInMillis() { return startTimeInMillis; } long getEndTimeInMillis() { - return startTimeInMillis + (expirationPeriod * 60 * 1000); + return startTimeInMillis + (expirationPeriod * 60L * 1000L); } String getRandomUser() { int userNum = random.nextInt(numMembers); From abb51130cd200b888a785c2d9e868b6fa6ec26ae Mon Sep 17 00:00:00 2001 From: eralmas7 Date: Sat, 15 Jul 2017 15:53:37 +0530 Subject: [PATCH 2/3] BEAM-934 Enabled firebug after fixing the bug. --- examples/java8/pom.xml | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/examples/java8/pom.xml b/examples/java8/pom.xml index 6fd29a496bb8..332fb16c1e42 100644 --- a/examples/java8/pom.xml +++ b/examples/java8/pom.xml @@ -154,18 +154,6 @@ - - - - - org.codehaus.mojo - findbugs-maven-plugin - - true - - - - From 462c66dc0466dfe543b1aeaf8970b43278839dfd Mon Sep 17 00:00:00 2001 From: eralmas7 Date: Sat, 15 Jul 2017 17:28:09 +0530 Subject: [PATCH 3/3] BEAM-934 Fixed code after review. --- .../beam/examples/complete/game/injector/InjectorUtils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/java8/src/main/java/org/apache/beam/examples/complete/game/injector/InjectorUtils.java b/examples/java8/src/main/java/org/apache/beam/examples/complete/game/injector/InjectorUtils.java index 8cba6c2d05f0..1667f3a46914 100644 --- a/examples/java8/src/main/java/org/apache/beam/examples/complete/game/injector/InjectorUtils.java +++ b/examples/java8/src/main/java/org/apache/beam/examples/complete/game/injector/InjectorUtils.java @@ -93,7 +93,7 @@ public static void createTopic(Pubsub client, String fullTopicName) Topic topic = client.projects().topics() .create(fullTopicName, new Topic()) .execute(); - System.out.printf("Topic %s was created.\n", topic.getName()); + System.out.printf("Topic %s was created.%n", topic.getName()); } } }