New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-4037] Add streaming wordcount snippets and test #5071

Merged
merged 1 commit into from Apr 10, 2018

Conversation

Projects
None yet
2 participants
@charlesccychen
Contributor

charlesccychen commented Apr 9, 2018

This change allows our documentation to refer to these tested streaming wordcount snippets.

@charlesccychen

This comment has been minimized.

Contributor

charlesccychen commented Apr 9, 2018

R: @aaltay
CC: @melap

@aaltay

aaltay approved these changes Apr 10, 2018

@aaltay

This comment has been minimized.

Contributor

aaltay commented Apr 10, 2018

LGTM. snippets_test is failing, please fix that.

@charlesccychen

This comment has been minimized.

Contributor

charlesccychen commented Apr 10, 2018

Sent out commit with # coding=utf-8 fix.

@aaltay

This comment has been minimized.

Contributor

aaltay commented Apr 10, 2018

Thank you I can merge once tests pass.

@charlesccychen

This comment has been minimized.

Contributor

charlesccychen commented Apr 10, 2018

retest this please

@aaltay

This comment has been minimized.

Contributor

aaltay commented Apr 10, 2018

Could you fix the lint errors:

Running pylint for module apache_beam:
************* Module apache_beam.examples.snippets.snippets
C:681, 0: Line too long (81/80) (line-too-long)
************* Module apache_beam.examples.snippets.snippets_test
C: 25, 0: standard import "import os" should be placed before "import mock" (wrong-import-order)
C: 26, 0: standard import "import tempfile" should be placed before "import mock" (wrong-import-order)
C: 27, 0: standard import "import unittest" should be placed before "import mock" (wrong-import-order)
C: 28, 0: standard import "import uuid" should be placed before "import mock" (wrong-import-order)
@charlesccychen

This comment has been minimized.

Contributor

charlesccychen commented Apr 10, 2018

Thanks, PTAL.

@aaltay aaltay merged commit 1422ff7 into apache:master Apr 10, 2018

2 of 3 checks passed

Jenkins: ./gradlew --info --continue --rerun-tasks -Pmaven_home=/home/jenkins/tools/maven/apache-maven-3.5.2 :javaPreCommit Build started sha1 is merged.
Details
Jenkins: ./gradlew --info --continue --rerun-tasks :goPreCommit SUCCESS
Details
Jenkins: ./gradlew --info --continue --rerun-tasks :pythonPreCommit SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment