New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename common_job_properties #5915

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@lgajowy
Contributor

lgajowy commented Jul 10, 2018

This PR renames common_job_properties.groovy file to use groovy's naming convention.


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
--- --- --- ---
@lgajowy

This comment has been minimized.

Contributor

lgajowy commented Jul 10, 2018

Run seed job

@lgajowy

This comment has been minimized.

Contributor

lgajowy commented Jul 10, 2018

Run seed job

4 similar comments
@lgajowy

This comment has been minimized.

Contributor

lgajowy commented Jul 10, 2018

Run seed job

@lgajowy

This comment has been minimized.

Contributor

lgajowy commented Jul 10, 2018

Run seed job

@lgajowy

This comment has been minimized.

Contributor

lgajowy commented Jul 10, 2018

Run seed job

@lgajowy

This comment has been minimized.

Contributor

lgajowy commented Jul 10, 2018

Run seed job

@lgajowy

This comment has been minimized.

Contributor

lgajowy commented Jul 10, 2018

Run seed job

2 similar comments
@lgajowy

This comment has been minimized.

Contributor

lgajowy commented Jul 10, 2018

Run seed job

@lgajowy

This comment has been minimized.

Contributor

lgajowy commented Jul 10, 2018

Run seed job

@lgajowy

This comment has been minimized.

Contributor

lgajowy commented Jul 10, 2018

@swegner @jasonkuster @alanmyrvold I think I broke the seed_job with this PR. I tried to run it from recent master branch (#5914) and it failed due to changes introduced in this PR. Standalone seed job works fine. Sorry for the trouble. Can you help with this?

@lgajowy lgajowy referenced this pull request Jul 10, 2018

Closed

This is just to run seed job again #5914

0 of 2 tasks complete
@@ -106,6 +106,7 @@ job('beam_SeedJob') {
dsl {
// A list or a glob of other groovy files to process.
external('.test-infra/jenkins/job_*.groovy')
external('.test-infra/jenkins/**/*Job.groovy')

This comment has been minimized.

@lgajowy

lgajowy Jul 10, 2018

Contributor

This is the line that broke the seed job elsewhere

@lgajowy lgajowy closed this Jul 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment