New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-5351] Fix missing pom.xml file in artifact jar. #6358

Merged
merged 1 commit into from Sep 10, 2018

Conversation

Projects
None yet
2 participants
@lukecwik
Member

lukecwik commented Sep 10, 2018

I also validate that the files exist and error out the build otherwise.


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
--- --- --- ---
[BEAM-5351] Fix missing pom.xml file in artifact jar.
I also validate that the files exist and error out the build otherwise.

@lukecwik lukecwik requested a review from charlesccychen Sep 10, 2018

@lukecwik

This comment has been minimized.

Show comment
Hide comment
@lukecwik
Member

lukecwik commented Sep 10, 2018

@charlesccychen

This comment has been minimized.

Show comment
Hide comment
@charlesccychen

charlesccychen Sep 10, 2018

Contributor

Thanks Luke, this LGTM. Please merge after tests pass.

Contributor

charlesccychen commented Sep 10, 2018

Thanks Luke, this LGTM. Please merge after tests pass.

@charlesccychen charlesccychen merged commit fff465d into apache:master Sep 10, 2018

3 of 4 checks passed

Website ("Run Website PreCommit") FAILURE
Details
Go ("Run Go PreCommit") SUCCESS
Details
Java ("Run Java PreCommit") SUCCESS
Details
Python ("Run Python PreCommit") SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment