Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Update instructions to post-commit policy web page #7095

Merged
merged 2 commits into from Dec 10, 2018

Conversation

Projects
None yet
3 participants
@HuangLED
Copy link
Contributor

HuangLED commented Nov 20, 2018

A summary of discussions in dev mailing list: https://lists.apache.org/thread.html/a558b4df08be926b5f4ee268e205f084d7b2442da4b4d8cfc7bfe39f@%3Cdev.beam.apache.org%3E

Staged URL: http://apache-beam-website-pull-requests.storage.googleapis.com/7095/contribute/postcommits-policies-details/index.html#inform_community


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status Build Status Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
Build Status --- --- ---

@HuangLED HuangLED force-pushed the HuangLED:update_postcommit_doc branch from e315967 to a40533c Nov 20, 2018

@HuangLED HuangLED force-pushed the HuangLED:update_postcommit_doc branch from a40533c to c3e636d Nov 20, 2018

@mxm

mxm approved these changes Nov 21, 2018

Copy link
Contributor

mxm left a comment

Thank you for updating the instructions. Looks good to me. Some minor comments inline.

Update website/src/contribute/postcommits-policies-details.md
Co-Authored-By: HuangLED <huangry@gmail.com>

@HuangLED HuangLED force-pushed the HuangLED:update_postcommit_doc branch from 336c58c to f976430 Nov 21, 2018

@HuangLED

This comment has been minimized.

Copy link
Contributor Author

HuangLED commented Nov 21, 2018

Thanks for the suggestions!

All edits applied in github UI and then squashed into one commit.

@robertwb

This comment has been minimized.

Copy link
Contributor

robertwb commented Dec 10, 2018

Thanks. Looks good to me too.

@robertwb robertwb merged commit 6e3cf84 into apache:master Dec 10, 2018

3 checks passed

RAT ("Run RAT PreCommit") SUCCESS
Details
Website ("Run Website PreCommit") SUCCESS
Details
Website_Stage_GCS ("Run Website_Stage_GCS PreCommit") SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.