Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-6032] Move PortableValidatesRunner configuration out of BeamModulePlugin #7173

Merged
merged 1 commit into from Dec 3, 2018

Conversation

@mxm
Copy link
Contributor

mxm commented Nov 30, 2018

This moves the test inclusions/exclusion from the BeamModulePlugin into the
specific Runner Gradle file.

CC: @angoenka @ryan-williams @tweise

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status Build Status Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
Build Status --- --- ---
@mxm mxm requested a review from angoenka Nov 30, 2018
@angoenka

This comment has been minimized.

Copy link
Contributor

angoenka commented Nov 30, 2018

We will also need to add the testCategories to runners/direct-java/build.gradle

@tweise
tweise approved these changes Dec 3, 2018
…lePlugin

This moves the test inclusions/exclusion from the BeamModulePlugin into the
specific Runner Gradle files.
@mxm

This comment has been minimized.

Copy link
Contributor Author

mxm commented Dec 3, 2018

The direct runner tests don't seem to be functional at the moment, but good point. Will replicate the current setup in the direct runner Gradle file.

@mxm mxm force-pushed the mxm:BEAM-6032 branch from 1e3d80f to 4baab19 Dec 3, 2018
@mxm mxm changed the title [BEAM-6032] Move PortableValidatesRunne configuration out of BeamModulePlugin [BEAM-6032] Move PortableValidatesRunner configuration out of BeamModulePlugin Dec 3, 2018
@mxm mxm merged commit 3432c04 into apache:master Dec 3, 2018
11 checks passed
11 checks passed
CommunityMetrics ("Run CommunityMetrics PreCommit") SUCCESS
Details
Go ("Run Go PreCommit") SUCCESS
Details
Java ("Run Java PreCommit") SUCCESS
Details
JavaPortabilityApi ("Run JavaPortabilityApi PreCommit") SUCCESS
Details
Java_Examples_Dataflow ("Run Java_Examples_Dataflow PreCommit") SUCCESS
Details
Portable_Python ("Run Portable_Python PreCommit") SUCCESS
Details
Python ("Run Python PreCommit") SUCCESS
Details
RAT ("Run RAT PreCommit") SUCCESS
Details
Spotless ("Run Spotless PreCommit") SUCCESS
Details
Website ("Run Website PreCommit") SUCCESS
Details
Website_Stage_GCS ("Run Website_Stage_GCS PreCommit") SUCCESS
Details
@mxm mxm deleted the mxm:BEAM-6032 branch Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.