[BEAM-6619] [BEAM-6593] fix autocomplete it test python 3 #8070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Python PostCommit |
|
Run Python PostCommit |
|
Run Python PostCommit |
tvalentyn
reviewed
Mar 19, 2019
| result = result | beam.Map(lambda k_vs: [k_vs[0], | ||
| k_vs[1][0][0], k_vs[1][0][1]]) | ||
| checksum = (result | ||
| | beam.Map(lambda x: int(compute_hash(x)[:8], 16)) |
There was a problem hiding this comment.
Note for other reviewers: this makes hash computation deterministic on Py3.
tvalentyn
approved these changes
Mar 19, 2019
|
Thanks, @Juta ! I have a small process suggestion - please @ mention me or other committers when a PR is ready for review. |
|
CCing a few committers who could merge: @aaltay , @markflyhigh , @charlesccychen . |
aaltay
approved these changes
Mar 19, 2019
|
@tvalentyn ok will do. Thanks for the reminder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The autocomplete test uses
hash()to check the result of the test. I verified that the result is the same in py3 as in py2 and computed the hash in py3 with PYTHONHASHSEED set to 0 to assure deterministic resultsPost-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.