Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-6978] Have dataflow service receive additional arguments needed to support SplittableDoFn. #8204

Merged
merged 2 commits into from Apr 5, 2019

Conversation

@lukecwik
Copy link
Member

lukecwik commented Apr 2, 2019


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@lukecwik

This comment has been minimized.

Copy link
Member Author

lukecwik commented Apr 2, 2019

@lukecwik lukecwik force-pushed the lukecwik:splittabledofn6 branch 5 times, most recently from 20fac9c to 0dc1864 Apr 2, 2019
@lukecwik

This comment has been minimized.

Copy link
Member Author

lukecwik commented Apr 3, 2019

Run Python PreCommit

@lukecwik

This comment has been minimized.

Copy link
Member Author

lukecwik commented Apr 3, 2019

Run Java PreCommit

@lukecwik

This comment has been minimized.

Copy link
Member Author

lukecwik commented Apr 3, 2019

Run Portable_Python PreCommit

… to support SplittableDoFn.
@lukecwik lukecwik force-pushed the lukecwik:splittabledofn6 branch from 0dc1864 to d1f4bbc Apr 3, 2019
if (use_fnapi and use_unified_worker and signature.is_splittable_dofn()):
restriction_coder = (
signature.get_restriction_provider().restriction_coder())
step.add_property('restriction_encoding',

This comment has been minimized.

Copy link
@robertwb

robertwb Apr 5, 2019

Contributor

Could you put this constant in PropertyNames?

This comment has been minimized.

Copy link
@lukecwik

lukecwik Apr 5, 2019

Author Member

Done

Thanks for pointing this out.

@lukecwik lukecwik merged commit 5fc6bf6 into apache:master Apr 5, 2019
8 checks passed
8 checks passed
Go ("Run Go PreCommit") SUCCESS
Details
Java ("Run Java PreCommit") SUCCESS
Details
Java_Examples_Dataflow ("Run Java_Examples_Dataflow PreCommit") SUCCESS
Details
Portable_Python ("Run Portable_Python PreCommit") SUCCESS
Details
Python ("Run Python PreCommit") SUCCESS
Details
Python_PVR_Flink ("Run Python_PVR_Flink PreCommit") SUCCESS
Details
RAT ("Run RAT PreCommit") SUCCESS
Details
Spotless ("Run Spotless PreCommit") SUCCESS
Details
ibzib added a commit to ibzib/beam that referenced this pull request Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.