Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-7351] increment ack deadline for flaky pubsub test #8752

Merged
merged 1 commit into from Jun 5, 2019

Conversation

Juta
Copy link
Contributor

@Juta Juta commented Jun 4, 2019

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@Juta
Copy link
Contributor Author

Juta commented Jun 4, 2019

Run Python PostCommit

@Juta
Copy link
Contributor Author

Juta commented Jun 4, 2019

R: @tvalentyn

@tvalentyn
Copy link
Contributor

I checked that streaming wordcount tests passed in all Py2 and Py3 test suites.

03:41:46 test_streaming_wordcount_it (apache_beam.examples.streaming_wordcount_it_test.StreamingWordCountIT) ... ok

We have other PRs in flight to address flakiness in other tests, so I think we can go ahead with the merge. @pabloem, could you please help with the merge? Thanks.

@tvalentyn
Copy link
Contributor

Thanks, @Juta !

@pabloem
Copy link
Member

pabloem commented Jun 4, 2019

I'd feel more comfortable having a passing run. I'll merge after tests pass.

@pabloem
Copy link
Member

pabloem commented Jun 4, 2019

Run Python PostCommit

@pabloem
Copy link
Member

pabloem commented Jun 4, 2019

hm I see what you mean. There's many broken tests. You're saying that there's fixes for the other tests in other PRs then?

@tvalentyn
Copy link
Contributor

We might not fix all of the tests in other PRs, but we may have more luck with another re-run. But as I said, the tests affected by this PR passed last time I looked into the logs, so I think it's safe to merge.

@tvalentyn
Copy link
Contributor

Run Python PostCommit

@tvalentyn
Copy link
Contributor

Kicked off another run of postcommits.

@pabloem pabloem merged commit 4973c57 into apache:master Jun 5, 2019
@pabloem
Copy link
Member

pabloem commented Jun 5, 2019

Thanks @tvalentyn @Juta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants