Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-7683] MongoDBIO.withQueryFn ignores custom filter #9004

Merged
merged 1 commit into from Jul 4, 2019

Conversation

Projects
None yet
2 participants
@chaimt
Copy link
Contributor

commented Jul 4, 2019

in the case of split more than 0, this user definied filter was overridded by the split filter

R: @jbonofre @iemejia

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

[BEAM-7683] - fix withQueryFn when split is more than 0
in the case of split more than 0, this user definied filter was overridded by the split filter

@iemejia iemejia self-requested a review Jul 4, 2019

@iemejia

iemejia approved these changes Jul 4, 2019

Copy link
Member

left a comment

Perfect ! LGTM. Thanks for bringing this fix.

@iemejia iemejia changed the title [BEAM-7683] - fix withQueryFn when split is more than 0 [BEAM-7683] MongoDBIO.withQueryFn ignores custom filter Jul 4, 2019

@iemejia iemejia merged commit cfecfb0 into apache:master Jul 4, 2019

5 checks passed

Java ("Run Java PreCommit") SUCCESS
Details
JavaPortabilityApi ("Run JavaPortabilityApi PreCommit") SUCCESS
Details
Java_Examples_Dataflow ("Run Java_Examples_Dataflow PreCommit") SUCCESS
Details
RAT ("Run RAT PreCommit") SUCCESS
Details
Spotless ("Run Spotless PreCommit") SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.