diff --git a/CHANGES.txt b/CHANGES.txt index 415d1a3f242..12a549995c6 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -164,6 +164,8 @@ Release 4.1.0 - 2012-05-31 BOOKKEEPER-146: TestConcurrentTopicAcquisition sometimes hangs (ivank) + BOOKKEEPER-285: TestZkSubscriptionManager quits due to NPE, so other tests are not run in hedwig server. (sijie) + bookkeeper-benchmark/ BOOKKEEPER-207: BenchBookie doesn't run correctly (ivank via fpj) diff --git a/hedwig-server/src/test/java/org/apache/hedwig/server/subscriptions/TestZkSubscriptionManager.java b/hedwig-server/src/test/java/org/apache/hedwig/server/subscriptions/TestZkSubscriptionManager.java index f6d533f6591..9558acf7b50 100644 --- a/hedwig-server/src/test/java/org/apache/hedwig/server/subscriptions/TestZkSubscriptionManager.java +++ b/hedwig-server/src/test/java/org/apache/hedwig/server/subscriptions/TestZkSubscriptionManager.java @@ -31,6 +31,7 @@ import org.apache.hedwig.protocol.PubSubProtocol.SubscribeRequest.CreateOrAttach; import org.apache.hedwig.server.common.ServerConfiguration; import org.apache.hedwig.server.topics.TrivialOwnAllTopicManager; +import org.apache.hedwig.server.persistence.LocalDBPersistenceManager; import org.apache.hedwig.util.ConcurrencyUtils; import org.apache.hedwig.util.Either; import org.apache.hedwig.util.Callback; @@ -50,7 +51,8 @@ public void setUp() throws Exception { super.setUp(); cfg = new ServerConfiguration(); final ScheduledExecutorService scheduler = Executors.newScheduledThreadPool(1); - sm = new ZkSubscriptionManager(zk, new TrivialOwnAllTopicManager(cfg, scheduler), null, cfg, scheduler); + sm = new ZkSubscriptionManager(zk, new TrivialOwnAllTopicManager(cfg, scheduler), + LocalDBPersistenceManager.instance(), cfg, scheduler); msgIdCallback = new Callback() { @Override public void operationFailed(Object ctx, final PubSubException exception) {