Skip to content

Improve Travis Build#1224

Closed
sijie wants to merge 1 commit into
apache:masterfrom
sijie:travis_wait
Closed

Improve Travis Build#1224
sijie wants to merge 1 commit into
apache:masterfrom
sijie:travis_wait

Conversation

@sijie

@sijie sijie commented Mar 2, 2018

Copy link
Copy Markdown
Member

Descriptions of the changes in this PR:

Problem

There are a couple of problem with current travis build

  • Enable buiding website on travis job if a PR is modifying site #1223 introduce set -e on script section, which it cause some weird early-exiting problem.
  • we run two installs. one is the default install by travis, the other one is install with apache-rat/spotbug checks in script section, which make the build slow.
  • travis_retry and travis_wait spread across different commands in the script section

Solution

  • move build logic into a bash script file and invoke the script
  • skip install section in travis

Result

This reduces travis build time by 10+ mins and make it stable

NOTES:

The changes under site and stream/distributedlog are used empty commits to trigger corresponding builds in travis.

*Problem*

There are a couple of problem with current travis build

- apache#1223 introduce `set -e` on script section, which it cause some weird early-existing problem.
- we run two installs. one is the default install by travis, the other one is install with apache-rat/spotbug checks in script section, which make the build slow.
- travis_retry and travis_wait spread across different commands in the script section

*Solution*

- move build logic into a bash script file and invoke the script
- skip install section in travis

*Result*

This reduces travis build time by 10+ mins and make it stable
@sijie sijie changed the title (WIP) Use travis_wait on running mvn install Improve Travis Build Mar 3, 2018
@sijie sijie added this to the 4.7.0 milestone Mar 3, 2018

@merlimat merlimat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jiazhai jiazhai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sijie

sijie commented Mar 3, 2018

Copy link
Copy Markdown
Member Author

The travis CI passed. the failure is on jenkins integration tests job (timeout at building docker image)

@sijie

sijie commented Mar 3, 2018

Copy link
Copy Markdown
Member Author

IGNORE IT CI

@sijie sijie self-assigned this Mar 3, 2018
@sijie sijie closed this in bd79862 Mar 3, 2018
@sijie sijie deleted the travis_wait branch July 16, 2018 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants