update default value of allocatorPoolingConcurrency #3001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set a more reasonable default value to avoid OutOfDirectMemoryError.
|
@eolivelli Please help to review it. |
hangc0276
reviewed
Jun 24, 2022
| @@ -1060,7 +1061,7 @@ public T setAllocatorPoolingPolicy(PoolingPolicy poolingPolicy) { | |||
| * @return the configured pooling concurrency for the allocator. | |||
| */ | |||
| public int getAllocatorPoolingConcurrency() { | |||
| return this.getInteger(ALLOCATOR_POOLING_CONCURRENCY, 2 * Runtime.getRuntime().availableProcessors()); | |||
| return this.getInteger(ALLOCATOR_POOLING_CONCURRENCY, PooledByteBufAllocator.defaultNumDirectArena()); | |||
There was a problem hiding this comment.
The default value of defaultNumDirectArena is 2 * cpus
https://github.com/netty/netty/blob/4e439264df0523fb6efce5f8f6c7c7fa74addd07/buffer/src/main/java/io/netty/buffer/PooledByteBufAllocator.java#L413-L418
There was a problem hiding this comment.
The default value of
defaultNumDirectArenais 2 * cpus https://github.com/netty/netty/blob/4e439264df0523fb6efce5f8f6c7c7fa74addd07/buffer/src/main/java/io/netty/buffer/PooledByteBufAllocator.java#L413-L418
Thanks for your reply. Netty default value use the min value between 2*cpus and max mem defaultChunkSize / 2 / 3 to avoid oom. And it helps me resolved bookeeper oom problem in my product environment. Can you help me to merge it?
DEFAULT_NUM_DIRECT_ARENA = Math.max(0,
SystemPropertyUtil.getInt(
"io.netty.allocator.numDirectArenas",
(int) Math.min(
defaultMinNumArena,
PlatformDependent.maxDirectMemory() / defaultChunkSize / 2 / 3)));
hangc0276
requested review from
eolivelli,
dlg99,
nicoloboschi,
shoothzj and
zymap
hangc0276
approved these changes
Jul 26, 2022
|
ping @merlimat @eolivelli @dlg99, Would you please help take a look? thanks. |
horizonzy
approved these changes
Jul 26, 2022
|
And there is a more suitable value for it. In we use When we calculate the concurrency, we should subtract the memory which writeCache and readCache total occupy. See: |
|
ping @sunshujie1990, would you please take a look at the last comment? |
sure |
dlg99
approved these changes
Jul 27, 2022
|
if no problem, please merge it,thanks @eolivelli @dlg99 @hangc0276 |
zymap
pushed a commit
that referenced
this pull request
Oct 26, 2022
Set a more reasonable default value to avoid OutOfDirectMemoryError. Descriptions of the changes in this PR: ### Motivation The default value of allocatorPoolingConcurrency is 2 * Runtime.getRuntime().availableProcessors(). It's used to specify the num of Arena in PooledByteBufAllocator. Assume: 40 processors 80 arena (processors*2) 2 chunk per arena 16MiB per chunk JVM's total direct mem should be larger then 80*2*16=2560MiB, otherwise OutOfDirectMemoryError occured. OutOfDirectMemoryError much more likely to occur in Docker, cause JDK versions earlier than Java SE 8U131 does not support Docker CPU limits. ### Changes Use Netty default arena num `PooledByteBufAllocator.defaultNumDirectArena()` as default allocatorPoolingConcurrency. (cherry picked from commit 01c8824)
hangc0276
pushed a commit
to hangc0276/bookkeeper
that referenced
this pull request
Nov 7, 2022
Set a more reasonable default value to avoid OutOfDirectMemoryError. Descriptions of the changes in this PR: ### Motivation The default value of allocatorPoolingConcurrency is 2 * Runtime.getRuntime().availableProcessors(). It's used to specify the num of Arena in PooledByteBufAllocator. Assume: 40 processors 80 arena (processors*2) 2 chunk per arena 16MiB per chunk JVM's total direct mem should be larger then 80*2*16=2560MiB, otherwise OutOfDirectMemoryError occured. OutOfDirectMemoryError much more likely to occur in Docker, cause JDK versions earlier than Java SE 8U131 does not support Docker CPU limits. ### Changes Use Netty default arena num `PooledByteBufAllocator.defaultNumDirectArena()` as default allocatorPoolingConcurrency. (cherry picked from commit 01c8824)
hangc0276
pushed a commit
to hangc0276/bookkeeper
that referenced
this pull request
Nov 7, 2022
Set a more reasonable default value to avoid OutOfDirectMemoryError. Descriptions of the changes in this PR: ### Motivation The default value of allocatorPoolingConcurrency is 2 * Runtime.getRuntime().availableProcessors(). It's used to specify the num of Arena in PooledByteBufAllocator. Assume: 40 processors 80 arena (processors*2) 2 chunk per arena 16MiB per chunk JVM's total direct mem should be larger then 80*2*16=2560MiB, otherwise OutOfDirectMemoryError occured. OutOfDirectMemoryError much more likely to occur in Docker, cause JDK versions earlier than Java SE 8U131 does not support Docker CPU limits. ### Changes Use Netty default arena num `PooledByteBufAllocator.defaultNumDirectArena()` as default allocatorPoolingConcurrency. (cherry picked from commit 01c8824)
nicoloboschi
pushed a commit
to datastax/bookkeeper
that referenced
this pull request
Jan 11, 2023
Set a more reasonable default value to avoid OutOfDirectMemoryError. Descriptions of the changes in this PR: ### Motivation The default value of allocatorPoolingConcurrency is 2 * Runtime.getRuntime().availableProcessors(). It's used to specify the num of Arena in PooledByteBufAllocator. Assume: 40 processors 80 arena (processors*2) 2 chunk per arena 16MiB per chunk JVM's total direct mem should be larger then 80*2*16=2560MiB, otherwise OutOfDirectMemoryError occured. OutOfDirectMemoryError much more likely to occur in Docker, cause JDK versions earlier than Java SE 8U131 does not support Docker CPU limits. ### Changes Use Netty default arena num `PooledByteBufAllocator.defaultNumDirectArena()` as default allocatorPoolingConcurrency. (cherry picked from commit 01c8824) (cherry picked from commit 35d0ecf)
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
Set a more reasonable default value to avoid OutOfDirectMemoryError. Descriptions of the changes in this PR: ### Motivation The default value of allocatorPoolingConcurrency is 2 * Runtime.getRuntime().availableProcessors(). It's used to specify the num of Arena in PooledByteBufAllocator. Assume: 40 processors 80 arena (processors*2) 2 chunk per arena 16MiB per chunk JVM's total direct mem should be larger then 80*2*16=2560MiB, otherwise OutOfDirectMemoryError occured. OutOfDirectMemoryError much more likely to occur in Docker, cause JDK versions earlier than Java SE 8U131 does not support Docker CPU limits. ### Changes Use Netty default arena num `PooledByteBufAllocator.defaultNumDirectArena()` as default allocatorPoolingConcurrency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set a more reasonable default value to avoid OutOfDirectMemoryError.
Descriptions of the changes in this PR:
Motivation
The default value of allocatorPoolingConcurrency is 2 * Runtime.getRuntime().availableProcessors(). It's used to specify the num of Arena in PooledByteBufAllocator.
Assume:
40 processors
80 arena (processors2)
2 chunk per arena
16MiB per chunk
JVM's total direct mem should be larger then 802*16=2560MiB, otherwise OutOfDirectMemoryError occured.
OutOfDirectMemoryError much more likely to occur in Docker, cause JDK versions earlier than Java SE 8U131 does not support Docker CPU limits.
Changes
Use Netty default arena num
PooledByteBufAllocator.defaultNumDirectArena()as default allocatorPoolingConcurrency.