BP-47 (task7): DbLedgerStorage add direct entry logger support #3366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rerun failure checks |
1 similar comment
|
rerun failure checks |
|
rerun failure checks |
dlg99
approved these changes
Jun 28, 2022
| @@ -91,6 +106,16 @@ public class DbLedgerStorage implements LedgerStorage { | |||
| static final String READ_AHEAD_CACHE_BATCH_SIZE = "dbStorage_readAheadCacheBatchSize"; | |||
| private static final int DEFAULT_READ_AHEAD_CACHE_BATCH_SIZE = 100; | |||
|
|
|||
| private static final long DEFAULT_DIRECT_IO_TOTAL_WRITEBUFFER_SIZE_MB = | |||
| (long) (0.125 * PlatformDependent.maxDirectMemory()) | |||
There was a problem hiding this comment.
PlatformDependent.estimateMaxDirectMemory()
See #2989
hangc0276
force-pushed
the
chenhang/directio-part7-dbledgerStorage-support-directio
branch
from
9a34b10
to
ff139a5
Compare
|
rerun failure checks |
|
Ping @merlimat @eolivelli @ivankelly @Vanlightly Please help take a look, thanks a lot. |
eolivelli
requested changes
Jun 30, 2022
| @Before | ||
| public void setup() throws Exception { | ||
| super.setup(); | ||
| conf.setProperty("dbStorage_directIOEntryLogger", true); |
There was a problem hiding this comment.
Is it possible to add some assertions in the tests about the fact that we really loaded this implementation?
The tests may pass because we aren't using the new implementation
|
rerun failure checks |
3 similar comments
|
rerun failure checks |
|
rerun failure checks |
|
rerun failure checks |
eolivelli
approved these changes
Jul 4, 2022
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Task 7 of BP-47, DbLedgerStorage add direct entry logger support.
This is the last Pr of BP-47
Modification
Add parameter
dbStorage_directIOEntryLoggerto control whether use direct entrylogger for DbLedgerStorage or not. Default value is false.Others
The commit is made by @ivankelly . This is the sub-task of #2932 , which was pushed out by @mauricebarnum. However, this PR contains too many changes and the number of code lines reaches 8K+, and it is hard to review. According to your suggestion #2932 (comment), and after communicating with @mauricebarnum, we are planning to divide the PR into 6 PRs, Please refer to #2943 (comment).
However, @mauricebarnum doesn't have enough time to deal with those issues, and we desperately need this feature. After communicating with @mauricebarnum and @merlimat , I help to work on dividing the PRs and pushing them out. We are hoping to contain this feature in BookKeeper 4.16.0