Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a judgement of waitTimeoutOnResponseBackpressureMs when throttling read response #3599

Closed
wants to merge 1 commit into from

Conversation

gaozhangmin
Copy link
Contributor

#3324 made v2 request support back pressure, if we set waitTimeoutOnResponseBackpressureMs, it won't take effect, because readWorkerThreadsThrottlingEnabled is enabled by default,

@gaozhangmin
Copy link
Contributor Author

rerun failure checks

Copy link
Member

@zymap zymap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it is different logic for them but they are trying to resolve the same problem. If you want to use the backpressure, you should know the throttle need to be disabled.

@gaozhangmin
Copy link
Contributor Author

gaozhangmin commented Nov 3, 2022

Because it is different logic for them but they are trying to resolve the same problem. If you want to use the backpressure, you should know the throttle need to be disabled

For the most who don't be familiar with the code, they won't know back pressure need disabling throttle and even throttle is enabled by default. @zymap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants