From bd0289634db6fb411a638a8f7febc95abcdbe91e Mon Sep 17 00:00:00 2001 From: gavingaozhangmin Date: Tue, 22 Nov 2022 14:46:18 +0800 Subject: [PATCH] Dont validate CompactionInterval when compaction is disabled --- .../java/org/apache/bookkeeper/conf/ServerConfiguration.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java index 05a4dec9075..1da07d526f2 100644 --- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java +++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java @@ -3164,10 +3164,10 @@ public void validate() throws ConfigurationException { throw new ConfigurationException("For persisiting explicitLac, journalFormatVersionToWrite should be >= 6" + "and FileInfoFormatVersionToWrite should be >= 1"); } - if (getMinorCompactionInterval() * SECOND < getGcWaitTime()) { + if (getMinorCompactionInterval() > 0 && getMinorCompactionInterval() * SECOND < getGcWaitTime()) { throw new ConfigurationException("minorCompactionInterval should be >= gcWaitTime."); } - if (getMajorCompactionInterval() * SECOND < getGcWaitTime()) { + if (getMajorCompactionInterval() > 0 && getMajorCompactionInterval() * SECOND < getGcWaitTime()) { throw new ConfigurationException("majorCompactionInterval should be >= gcWaitTime."); } }