New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 418: bump docker to use bk - 4.5.0 #436

Closed
wants to merge 1 commit into
base: master
from

Conversation

@zhaijack
Contributor

zhaijack commented Aug 11, 2017

Descriptions of the changes in this PR:

  • bump the docker image to use 4.5.0 binary, update pgp_key and bk version.
  • delete yum install for md5sum and sha1sum, since they are already in coreutils, which is default installed; and left them here will report error: 'No Match for argument: md5sum/sha1sum', while 'yum remove' in docker build.

have tested by running make run-dice.

@eolivelli

+1

@caiok

caiok approved these changes Aug 11, 2017

+1 Tested on my pc.

@zhaijack After the merge we need to cherry pick to the 4.5.0 branch, am I correct? Will we support 4.4.0 committing docker files in 4.4.0 branch too?

@zhaijack

This comment has been minimized.

Show comment
Hide comment
@zhaijack

zhaijack Aug 11, 2017

Contributor

@caiok @eolivelli Thanks for your review.
@caiok, Yes , it need cherry pick for 4.5.0, thanks for the reminder. I would like to do it after this merge.
Regarding 4.4.0, one issue is that the ZooKeeperMain not work as expected (more info contained in issue #418). If support 4.4.0 branch, in docker file, we may need some more change, like download latest zk, and replace ZooKeeperMain in entrypoint.sh with the downloaded zk, for better support.
That seems not simple cherry pick, I am not sure if this will bring trouble to code management.
@sijie , what do you think 4.4.0?

Contributor

zhaijack commented Aug 11, 2017

@caiok @eolivelli Thanks for your review.
@caiok, Yes , it need cherry pick for 4.5.0, thanks for the reminder. I would like to do it after this merge.
Regarding 4.4.0, one issue is that the ZooKeeperMain not work as expected (more info contained in issue #418). If support 4.4.0 branch, in docker file, we may need some more change, like download latest zk, and replace ZooKeeperMain in entrypoint.sh with the downloaded zk, for better support.
That seems not simple cherry pick, I am not sure if this will bring trouble to code management.
@sijie , what do you think 4.4.0?

@eolivelli

This comment has been minimized.

Show comment
Hide comment
@eolivelli

eolivelli Aug 11, 2017

Contributor

I think that as 4.5 bookie is fully compatible with 4.4 clients we can support only 4.5 onwards

Contributor

eolivelli commented Aug 11, 2017

I think that as 4.5 bookie is fully compatible with 4.4 clients we can support only 4.5 onwards

@sijie

This comment has been minimized.

Show comment
Hide comment
@sijie

sijie Aug 11, 2017

Contributor

since docker files are added for 4.5.0, I don't think we need to support previous releases. let's keep things simpler to just support 4.5.0 and onwards.

Contributor

sijie commented Aug 11, 2017

since docker files are added for 4.5.0, I don't think we need to support previous releases. let's keep things simpler to just support 4.5.0 and onwards.

@sijie

This comment has been minimized.

Show comment
Hide comment
@sijie

sijie Aug 11, 2017

Contributor

FYI. I also cherry-picked the docker changes to branch 4.5. once this merge, the docker change would be in branch 4.5.

However, I'd like tho hold on retagging the 4.5.0 release. because, based on the comment in https://issues.apache.org/jira/browse/INFRA-14756, we can't mark the images generated by dockerhub autobuilds as official apache image based on apache policy. so I would like to wait for INFRA's response before we move on. If dockerhub builds is not the right approach to generate the official apache image, we have to take a different approach.

Contributor

sijie commented Aug 11, 2017

FYI. I also cherry-picked the docker changes to branch 4.5. once this merge, the docker change would be in branch 4.5.

However, I'd like tho hold on retagging the 4.5.0 release. because, based on the comment in https://issues.apache.org/jira/browse/INFRA-14756, we can't mark the images generated by dockerhub autobuilds as official apache image based on apache policy. so I would like to wait for INFRA's response before we move on. If dockerhub builds is not the right approach to generate the official apache image, we have to take a different approach.

@zhaijack

This comment has been minimized.

Show comment
Hide comment
@zhaijack

zhaijack Aug 11, 2017

Contributor

Got it. Let's wait for the answer.

Contributor

zhaijack commented Aug 11, 2017

Got it. Let's wait for the answer.

@sijie

This comment has been minimized.

Show comment
Hide comment
@sijie

sijie Aug 11, 2017

Contributor

@zhaijack @caiok @eolivelli based on the response on https://issues.apache.org/jira/browse/INFRA-14756, Dockerhub is not the official channel for hosting
docker images. that means any docker images we have to mark them as non-official.

as the community, we can still merge this pull request and publish the docker images. however unfortunately these images have to be marked as non-official, we have to state that in documentation if we are writing the docker related documentation.

Contributor

sijie commented Aug 11, 2017

@zhaijack @caiok @eolivelli based on the response on https://issues.apache.org/jira/browse/INFRA-14756, Dockerhub is not the official channel for hosting
docker images. that means any docker images we have to mark them as non-official.

as the community, we can still merge this pull request and publish the docker images. however unfortunately these images have to be marked as non-official, we have to state that in documentation if we are writing the docker related documentation.

@sijie

This comment has been minimized.

Show comment
Hide comment
@sijie

sijie Aug 11, 2017

Contributor

merging this now.

  • merge this to both master and branch-4.5
  • git checkout a new branch from tag release-4.5.0 (because it was created before docker files are added)
  • cherry-pick the docker changes to that the temp branch, retag release-4.5.0 to include the docker files

I will update the release_guide about it.

Contributor

sijie commented Aug 11, 2017

merging this now.

  • merge this to both master and branch-4.5
  • git checkout a new branch from tag release-4.5.0 (because it was created before docker files are added)
  • cherry-pick the docker changes to that the temp branch, retag release-4.5.0 to include the docker files

I will update the release_guide about it.

@sijie sijie added this to the 4.6.0 milestone Aug 11, 2017

@sijie sijie closed this in 7395408 Aug 11, 2017

@sijie sijie added the release/4.5.1 label Aug 11, 2017

sijie added a commit that referenced this pull request Aug 11, 2017

ISSUE #418: bump docker to use bk - 4.5.0
Descriptions of the changes in this PR:
-  bump the docker image to use 4.5.0 binary, update pgp_key and bk version.
-  delete yum install for md5sum and sha1sum, since they are already in coreutils, which is default installed; and left them here will report error: 'No Match for argument: md5sum/sha1sum', while 'yum remove' in docker build.

have tested by running make run-dice.

Author: zhaijack <zhaijia03@gmail.com>

Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Francesco Caliumi <None>

This closes #436 from zhaijack/issue_418, closes #418

(cherry picked from commit 7395408)
Signed-off-by: Sijie Guo <sijie@apache.org>
@sijie

This comment has been minimized.

Show comment
Hide comment
@sijie

sijie Aug 12, 2017

Contributor

cherry-picked all docker related to changes to both branch-4.5 and release-4.5.0 (retagged).

4.5.0 image is built - https://hub.docker.com/r/apache/bookkeeper/tags/

@zhaijack @caiok can you guys verify this one?

Contributor

sijie commented Aug 12, 2017

cherry-picked all docker related to changes to both branch-4.5 and release-4.5.0 (retagged).

4.5.0 image is built - https://hub.docker.com/r/apache/bookkeeper/tags/

@zhaijack @caiok can you guys verify this one?

@zhaijack

This comment has been minimized.

Show comment
Hide comment
@zhaijack

zhaijack Aug 12, 2017

Contributor

@sijie Thanks a lot for the work.
And I have verified 4.5.0 image. it worked well.

Contributor

zhaijack commented Aug 12, 2017

@sijie Thanks a lot for the work.
And I have verified 4.5.0 image. it worked well.

sijie added a commit to sijie/bookkeeper that referenced this pull request Aug 14, 2017

ISSUE #418: bump docker to use bk - 4.5.0
Descriptions of the changes in this PR:
-  bump the docker image to use 4.5.0 binary, update pgp_key and bk version.
-  delete yum install for md5sum and sha1sum, since they are already in coreutils, which is default installed; and left them here will report error: 'No Match for argument: md5sum/sha1sum', while 'yum remove' in docker build.

have tested by running make run-dice.

Author: zhaijack <zhaijia03@gmail.com>

Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Francesco Caliumi <None>

This closes #436 from zhaijack/issue_418, closes #418

(cherry picked from commit 7395408)
Signed-off-by: Sijie Guo <sijie@apache.org>
@caiok

This comment has been minimized.

Show comment
Hide comment
@caiok

caiok Aug 14, 2017

Contributor

@sijie Thanks for the work, image 4.5.0 works well.

@sijie @zhaijack Now we should make "latest" tag (the default tag and the most used one) to refer to 4.5.0, because it's still referring to 4.4.0.

Contributor

caiok commented Aug 14, 2017

@sijie Thanks for the work, image 4.5.0 works well.

@sijie @zhaijack Now we should make "latest" tag (the default tag and the most used one) to refer to 4.5.0, because it's still referring to 4.4.0.

@zhaijack

This comment has been minimized.

Show comment
Hide comment
@zhaijack

zhaijack Aug 14, 2017

Contributor

@caiok, latest should be 4.5.0. But seems the auto build failed for not able to connect to gpg server, please reference build details here:
https://hub.docker.com/r/apache/bookkeeper/builds/bkvstyewexhym5ev94wce4n/
And @sijie has send out a mail which mentioned this.

Contributor

zhaijack commented Aug 14, 2017

@caiok, latest should be 4.5.0. But seems the auto build failed for not able to connect to gpg server, please reference build details here:
https://hub.docker.com/r/apache/bookkeeper/builds/bkvstyewexhym5ev94wce4n/
And @sijie has send out a mail which mentioned this.

@zhaijack zhaijack deleted the zhaijack:issue_418 branch Aug 15, 2017

caiok added a commit to caiok/bookkeeper that referenced this pull request Aug 28, 2017

ISSUE #418: bump docker to use bk - 4.5.0
Descriptions of the changes in this PR:
-  bump the docker image to use 4.5.0 binary, update pgp_key and bk version.
-  delete yum install for md5sum and sha1sum, since they are already in coreutils, which is default installed; and left them here will report error: 'No Match for argument: md5sum/sha1sum', while 'yum remove' in docker build.

have tested by running make run-dice.

Author: zhaijack <zhaijia03@gmail.com>

Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Francesco Caliumi <None>

This closes #436 from zhaijack/issue_418, closes #418
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment